linux-kernel - Re: [PATCH v2] pmdomain: Use str_enable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMuHMdV2Ar95nrmH=NTwY+pkrg6nD-sNoVG7MJY7ofJF4N3bNA@mail.gmail.com>
Date: Thu, 12 Jun 2025 17:53:55 +0200
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: shao.mingyin@....com.cn
Cc: ulf.hansson@...aro.org, changhuang.liang@...rfivetech.com, 
	geert+renesas@...der.be, magnus.damm@...il.com, heiko@...ech.de, 
	krzk@...nel.org, alim.akhtar@...sung.com, walker.chen@...rfivetech.com, 
	sebastian.reichel@...labora.com, detlev.casanova@...labora.com, 
	finley.xiao@...k-chips.com, shawn.lin@...k-chips.com, pgwipeout@...il.com, 
	qiu.yutan@....com.cn, linux-pm@...r.kernel.org, 
	linux-renesas-soc@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-arm-kernel@...ts.infradead.org, linux-rockchip@...ts.infradead.org, 
	linux-samsung-soc@...r.kernel.org, yang.yang29@....com.cn, 
	xu.xin16@....com.cn, yang.tao172@....com.cn, ye.xingchen@....com.cn
Subject: Re: [PATCH v2] pmdomain: Use str_enable_disable-like helpers

Hi Mingyin,

On Tue, 10 Jun 2025 at 13:34, <shao.mingyin@....com.cn> wrote:
> From: Shao Mingyin <shao.mingyin@....com.cn>
>
> Replace ternary (condition ? "enable" : "disable") syntax and ternary
> (condition ? "on" : "off") syntax with helpers from
> string_choices.h because:
> 1. Simple function call with one argument is easier to read.  Ternary
>    operator has three arguments and with wrapping might lead to quite
>    long code.
> 2. Is slightly shorter thus also easier to read.
> 3. It brings uniformity in the text - same string.
> 4. Allows deduping by the linker, which results in a smaller binary
>    file.
>
> Signed-off-by: Shao Mingyin <shao.mingyin@....com.cn>
> ---
> v2:
>  %sable ==> %s in jh71xx_pmu_dev()

Thanks for the update!

While I already provided my Rb-tag on Krzysztof's original [1], your
version is whitespace-damaged (TABs replaced by spaces), and thus
cannot be applied.

[1] https://lore.kernel.org/all/CAMuHMdXJ57mATWW4AnBedn+D7TQ4PadkJ642daquFtAo=wZFrQ@mail.gmail.com/

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds