linux-kernel - Re: Unused event xfs_growfs_check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250612174758.GN6179@frogsfrogsfrogs>
Date: Thu, 12 Jun 2025 10:47:58 -0700
From: "Darrick J. Wong" <djwong@...nel.org>
To: Steven Rostedt <rostedt@...dmis.org>
Cc: LKML <linux-kernel@...r.kernel.org>, linux-xfs@...r.kernel.org,
	Carlos Maiolino <cem@...nel.org>, Christoph Hellwig <hch@....de>
Subject: Re: Unused event xfs_growfs_check_rtgeom

On Thu, Jun 12, 2025 at 01:10:21PM -0400, Steven Rostedt wrote:
> I have code that will cause a warning if a trace event or tracepoint is
> created but not used. Trace events can take up to 5K of memory in text
> and meta data per event. There's a lot of events in the XFS file system
> that are not used, but one in particular was added by commit
> 59a57acbce282 ("xfs: check that the rtrmapbt maxlevels doesn't increase
> when growing fs"). That event is xfs_growfs_check_rtgeom, but it was
> never called.
> 
> It looks like it was just an oversight. I'm holding off from deleting
> it as it may still be valid but just never been added. It was added
> relatively recently.

Yes that's a bug.  Will send a fix shortly.

--D

> -- Steve