linux-kernel - Re: Unused event xfs_growfs_check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250612144608.525860bc@batman.local.home>
Date: Thu, 12 Jun 2025 14:46:08 -0400
From: Steven Rostedt <rostedt@...dmis.org>
To: "Darrick J. Wong" <djwong@...nel.org>
Cc: LKML <linux-kernel@...r.kernel.org>, linux-xfs@...r.kernel.org, Carlos
 Maiolino <cem@...nel.org>, Christoph Hellwig <hch@....de>
Subject: Re: Unused event xfs_growfs_check_rtgeom

On Thu, 12 Jun 2025 10:47:37 -0700
"Darrick J. Wong" <djwong@...nel.org> wrote:

> On Thu, Jun 12, 2025 at 01:16:51PM -0400, Steven Rostedt wrote:
> > I also found events: xfs_metadir_link and xfs_metadir_start_link are
> > defined in fs/xfs/libxfs/xfs_metadir.c in a #ifndef __KERNEL__ section.
> > 
> > Are these events ever used? Why are they called in !__KERNEL__ code?  
> 
> libxfs is shared with userspace, and xfs_repair uses them to relink old
> quota files.
>

Does this userspace use these trace events? If so, I think the events
need to have an:

 #ifndef __KERENL__

around them too.

-- Steve