linux-kernel - Re: Unused event xfs_growfs_check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250612165850.399fce22@batman.local.home>
Date: Thu, 12 Jun 2025 16:58:50 -0400
From: Steven Rostedt <rostedt@...dmis.org>
To: "Darrick J. Wong" <djwong@...nel.org>
Cc: LKML <linux-kernel@...r.kernel.org>, linux-xfs@...r.kernel.org, Carlos
 Maiolino <cem@...nel.org>, Christoph Hellwig <hch@....de>
Subject: Re: Unused event xfs_growfs_check_rtgeom

On Thu, 12 Jun 2025 10:47:58 -0700
"Darrick J. Wong" <djwong@...nel.org> wrote:

> On Thu, Jun 12, 2025 at 01:10:21PM -0400, Steven Rostedt wrote:
> > I have code that will cause a warning if a trace event or tracepoint is
> > created but not used. Trace events can take up to 5K of memory in text
> > and meta data per event. There's a lot of events in the XFS file system
> > that are not used, but one in particular was added by commit
> > 59a57acbce282 ("xfs: check that the rtrmapbt maxlevels doesn't increase
> > when growing fs"). That event is xfs_growfs_check_rtgeom, but it was
> > never called.
> > 
> > It looks like it was just an oversight. I'm holding off from deleting
> > it as it may still be valid but just never been added. It was added
> > relatively recently.  
> 
> Yes that's a bug.  Will send a fix shortly.
> 

Hmm, this looks like another event that may have been forgotten to be added:

  xfs_discard_rtrelax

It was added by 3ba3ab1f671 ("xfs: enable FITRIM on the realtime
device") but never called.

As well as event xfs_log_cil_return which was added by c1220522ef4
("xfs: grant heads track byte counts, not LSNs")

And in commit defee8dff2b2 ("xfs: online repair of realtime bitmaps for
a realtime group"), the following events were added but not used:

  xrep_rtbitmap_load
  xrep_rtbitmap_load_word
  xrep_rtbitmap_load_words

Commit e6c9e75fbe79 ("xfs: move files to orphanage instead of letting
nlinks drop to zero") Added:

  xrep_nlinks_set_record

Commit dbbdbd00863 ("xfs: repair problems in CoW forks") added:

  xrep_cow_free_staging

I'll be sending patches that removes or hides other events that are no
longer used.

-- Steve

-- Steve