linux-kernel - Re: [PATCH v3 2/9] Workqueue: replace use of system_wq with system_percpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAAofZF7X2Uo7Epqd4zi6+AqvdP2XFWb+zJq6C1f0bK6y0S-Zdg@mail.gmail.com>
Date: Thu, 12 Jun 2025 11:39:19 +0200
From: Marco Crivellari <marco.crivellari@...e.com>
To: Tejun Heo <tj@...nel.org>
Cc: linux-kernel@...r.kernel.org, Lai Jiangshan <jiangshanlai@...il.com>, 
	Thomas Gleixner <tglx@...utronix.de>, Frederic Weisbecker <frederic@...nel.org>, 
	Sebastian Andrzej Siewior <bigeasy@...utronix.de>, Michal Hocko <mhocko@...e.com>
Subject: Re: [PATCH v3 2/9] Workqueue: replace use of system_wq with system_percpu_wq

Hi,

> I think this needs to be broken up per subsystem.

Do you think we should do the same with patch 3/9 ?
There are less files changed (79) tho, maybe it is not
necessary.

> Can you please post the workqueue patches to add
> all the new things?

I will do a new series (starting from v1, I would say) with:
- new wq(s) [actual P 1]
- new WQ_PERCPU flag [actual P 3]
- doc changes [actual P 9]

I will likely send these patches by the end of the day.

> I'll apply them to a branch and then you can send out per-subsys
> patches with the description explaining what's going on and asking
> how the patch should be routed including what wq branch to pull
> from if the subsys wants to route the patches through their tree.

So that means, if I understand correctly:
- send the new percpu patches per subsys (I will start now breaking up
by subsys)
- send the same system_dfl_wq patch (if we're not going to split per-subsys)
- send the WQ_PERCPU changes per subsys and the other patch that addresses
  the rest.

In summary, that means send all the patches of this v3, except for
those mentioned
above (P1, 3, 9), and of course the new patches adding
system_percpu_wq per-subsys.

But I'm not sure I understand the next part. Where should I ask those things?
For every single patch (commit log) or directly in the new cover letter?

Sorry for the dumb questions.

Thank you!

On Wed, Jun 11, 2025 at 11:01 PM Tejun Heo <tj@...nel.org> wrote:
>
> On Wed, Jun 11, 2025 at 03:14:31PM +0200, Marco Crivellari wrote:
> >  110 files changed, 208 insertions(+), 191 deletions(-)
>
> I think this needs to be broken up per subsystem. Can you please post the
> workqueue patches to add all the new things? I'll apply them to a branch and
> then you can send out per-subsys patches with the description explaining
> what's going on and asking how the patch should be routed including what wq
> branch to pull from if the subsys wants to route the patches through their
> tree.
>
> Thanks.
>
> --
> tejun



--

Marco Crivellari

L3 Support Engineer, Technology & Product




marco.crivellari@...e.com