linux-kernel - Re: [PATCH v9 5/7] ACPI: APEI: EINJ: Create debugfs files to enter device id and syndrome

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <684c5e20b406a_224b7e2947b@iweiny-mobl.notmuch>
Date: Fri, 13 Jun 2025 12:21:36 -0500
From: Ira Weiny <ira.weiny@...el.com>
To: Zaid Alali <zaidal@...amperecomputing.com>, <rafael@...nel.org>,
	<lenb@...nel.org>, <james.morse@....com>, <tony.luck@...el.com>,
	<bp@...en8.de>, <kees@...nel.org>, <gustavoars@...nel.org>,
	<Jonathan.Cameron@...wei.com>, <sudeep.holla@....com>,
	<jonathanh@...dia.com>, <u.kleine-koenig@...libre.com>,
	<dan.carpenter@...aro.org>, <viro@...iv.linux.org.uk>, <ira.weiny@...el.com>,
	<alison.schofield@...el.com>, <dan.j.williams@...el.com>,
	<gregkh@...uxfoundation.org>, <peterz@...radead.org>, <dave.jiang@...el.com>,
	<Benjamin.Cheatham@....com>, <linux-acpi@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <linux-hardening@...r.kernel.org>
Subject: Re: [PATCH v9 5/7] ACPI: APEI: EINJ: Create debugfs files to enter
 device id and syndrome

Zaid Alali wrote:
> From: Tony Luck <tony.luck@...el.com>
> 
> EINJv2 allows users to inject multiple errors at the same time by
> specifying the device id and syndrome bits for each error in a flex
> array.
> 
> Create files in the einj debugfs directory to enter data for each
> device id and syndrome value. Note that the specification says these
> are 128-bit little-endian values. Linux doesn't have a handy helper
> to manage objects of this type.

I do wonder if it would be better to make 128 bit versions in debugfs.
Because the next person to need them is unlikely to know they exist
here...

That said this looks fine for now.

Reviewed-by: Ira Weiny <ira.weiny@...el.com>

[snip]