linux-kernel - Re: [PATCH v9 4/7] ACPI: APEI: EINJ: Discover EINJv2 parameters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <684c586dc0268_224888294ae@iweiny-mobl.notmuch>
Date: Fri, 13 Jun 2025 11:57:17 -0500
From: Ira Weiny <ira.weiny@...el.com>
To: Zaid Alali <zaidal@...amperecomputing.com>, <rafael@...nel.org>,
	<lenb@...nel.org>, <james.morse@....com>, <tony.luck@...el.com>,
	<bp@...en8.de>, <kees@...nel.org>, <gustavoars@...nel.org>,
	<Jonathan.Cameron@...wei.com>, <sudeep.holla@....com>,
	<jonathanh@...dia.com>, <u.kleine-koenig@...libre.com>,
	<dan.carpenter@...aro.org>, <viro@...iv.linux.org.uk>, <ira.weiny@...el.com>,
	<alison.schofield@...el.com>, <dan.j.williams@...el.com>,
	<gregkh@...uxfoundation.org>, <peterz@...radead.org>, <dave.jiang@...el.com>,
	<Benjamin.Cheatham@....com>, <linux-acpi@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <linux-hardening@...r.kernel.org>
Subject: Re: [PATCH v9 4/7] ACPI: APEI: EINJ: Discover EINJv2 parameters

Zaid Alali wrote:
> The EINJv2 set_error_type_with_address structure has a flex array
> to hold the component IDs and syndrome values used when injecting
> multiple errors at once.
> 
> Discover the size of this array by taking the address from the
> ACPI_EINJ_SET_ERROR_TYPE_WITH_ADDRESS entry in the EINJ table
> and reading the BIOS copy of the structure.
> 
> Derive the maximum number of components from the length field
> in the einjv2_extension_struct at the end of the BIOS copy.
> 
> Map the whole of the structure into kernel memory (and unmap
> on module unload).
> 
> [Tony: Code unchanged from Zaid's original. New commit message]
> 
> Reviewed-by: Tony Luck <tony.luck@...el.com>
> Signed-off-by: Zaid Alali <zaidal@...amperecomputing.com>

Reviewed-by: Ira Weiny <ira.weiny@...el.com>

[snip]