linux-kernel - Re: [syzbot] [atm?] KMSAN: uninit-value in atmtcp_c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250613030043.226990-1-kuni1840@gmail.com>
Date: Thu, 12 Jun 2025 20:00:38 -0700
From: Kuniyuki Iwashima <kuni1840@...il.com>
To: syzbot+1d3c235276f62963e93a@...kaller.appspotmail.com
Cc: 3chas3@...il.com,
	kuni1840@...il.com,
	kuniyu@...gle.com,
	linux-atm-general@...ts.sourceforge.net,
	linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org,
	syzkaller-bugs@...glegroups.com
Subject: Re: [syzbot] [atm?] KMSAN: uninit-value in atmtcp_c_send

From: syzbot <syzbot+1d3c235276f62963e93a@...kaller.appspotmail.com>
Date: Thu, 12 Jun 2025 19:40:03 -0700
> Hello,
> 
> syzbot tried to test the proposed patch but the build/boot failed:
> 
> drivers/atm/atmtcp.c:293:24: error: use of undeclared identifier 'atmtcp_hdr'; did you mean 'atm_tcp_ops'?

Oops, I forgot struct :/

#syz test

diff --git a/drivers/atm/atmtcp.c b/drivers/atm/atmtcp.c
index d4aa0f353b6c..96c0969ce584 100644
--- a/drivers/atm/atmtcp.c
+++ b/drivers/atm/atmtcp.c
@@ -288,7 +288,11 @@ static int atmtcp_c_send(struct atm_vcc *vcc,struct sk_buff *skb)
 	struct sk_buff *new_skb;
 	int result = 0;
 
-	if (!skb->len) return 0;
+	if (!skb->len)
+		return 0;
+	if (skb->len < sizeof(struct atmtcp_hdr))
+		return -EINVAL;
+
 	dev = vcc->dev_data;
 	hdr = (struct atmtcp_hdr *) skb->data;
 	if (hdr->length == ATMTCP_HDR_MAGIC) {