linux-kernel - RE: [PATCH v0 3/5] arm64: dts: aspeed: Add initial AST2700 SoC device tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID:
 <OS8PR06MB754143A2AC8D351D8E715685F277A@OS8PR06MB7541.apcprd06.prod.outlook.com>
Date: Fri, 13 Jun 2025 02:54:14 +0000
From: Ryan Chen <ryan_chen@...eedtech.com>
To: Krzysztof Kozlowski <krzk@...nel.org>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
	Joel Stanley <joel@....id.au>, Andrew Jeffery <andrew@...econstruct.com.au>,
	Catalin Marinas <catalin.marinas@....com>, Will Deacon <will@...nel.org>,
	Arnd Bergmann <arnd@...db.de>, Bjorn Andersson
	<bjorn.andersson@....qualcomm.com>, Geert Uytterhoeven
	<geert@...ux-m68k.org>, Nishanth Menon <nm@...com>, "nfraprado@...labora.com"
	<nfraprado@...labora.com>, Taniya Das <quic_tdas@...cinc.com>, Lad Prabhakar
	<prabhakar.mahadev-lad.rj@...renesas.com>, Kuninori Morimoto
	<kuninori.morimoto.gx@...esas.com>, Eric Biggers <ebiggers@...gle.com>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-aspeed@...ts.ozlabs.org"
	<linux-aspeed@...ts.ozlabs.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "soc@...ts.linux.dev" <soc@...ts.linux.dev>,
	Mo Elbadry <elbadrym@...gle.com>, Rom Lemarchand <romlem@...gle.com>, William
 Kennington <wak@...gle.com>, Yuxiao Zhang <yuxiaozhang@...gle.com>,
	"wthai@...dia.com" <wthai@...dia.com>, "leohu@...dia.com" <leohu@...dia.com>,
	"dkodihalli@...dia.com" <dkodihalli@...dia.com>, "spuranik@...dia.com"
	<spuranik@...dia.com>
Subject: RE: [PATCH v0 3/5] arm64: dts: aspeed: Add initial AST2700 SoC device
 tree

> Subject: Re: [PATCH v0 3/5] arm64: dts: aspeed: Add initial AST2700 SoC device
> tree
> 
> On 12/06/2025 12:09, Ryan Chen wrote:
> > +
> > +	soc0: soc@...00000 {
> > +		compatible = "simple-bus";
> > +		reg = <0x0 0x10000000 0x10000000>;
> > +		#address-cells = <2>;
> > +		#size-cells = <1>;
> > +		ranges;
> > +
> > +		syscon0: syscon@...02000 {
> > +			compatible = "aspeed,ast2700-scu0", "syscon", "simple-mfd";
> 
> This makes no sense - no children here.
> 
> > +			reg = <0x0 0x12c02000 0x1000>;
> > +			ranges = <0x0 0x0 0 0x12c02000 0x1000>;
> 
> Neither this.
> 
> > +			#address-cells = <2>;
> > +			#size-cells = <1>;
> 
> Nor this.


I will add by following. 
                 syscon0: syscon@...02000 {
                        compatible = "aspeed,ast2700-scu0", "syscon", "simple-mfd";
                        reg = <0x0 0x12c02000 0x0 0x1000>;
                        ranges = <0x0 0x0 0 0x12c02000 0 0x1000>;
                        #address-cells = <2>;
                        #size-cells = <2>;
                        #clock-cells = <1>;
                        #reset-cells = <1>;

                        silicon-id@0 {
                                compatible = "aspeed,ast2700-silicon-id", "aspeed,silicon-id";
                                reg = <0 0x0 0 0x4>;
                        };

                        scu_ic0: interrupt-controller@1D0 {
                                #interrupt-cells = <1>;
                                compatible = "aspeed,ast2700-scu-ic0";
                                reg = <0 0x1d0 0 0xc>;
                                interrupts = <GIC_SPI 97 IRQ_TYPE_LEVEL_HIGH>;
                                interrupt-controller;
                        };

                        scu_ic1: interrupt-controller@1E0 {
                                #interrupt-cells = <1>;
                                compatible = "aspeed,ast2700-scu-ic1";
                                reg = <0 0x1e0 0 0xc>;
                                interrupts = <GIC_SPI 98 IRQ_TYPE_LEVEL_HIGH>;
                                interrupt-controller;
                        };

                        pinctrl0: pinctrl@400 {
                                compatible = "aspeed,ast2700-soc0-pinctrl";
                                reg = <0 0x400 0 0x600>;
                        };
                };

              syscon1: syscon@...02000 {
                        compatible = "aspeed,ast2700-scu1", "syscon", "simple-mfd";
                        reg = <0x0 0x14c02000 0x0 0x1000>;
                        ranges = <0x0 0x0 0x0 0x14c02000 0x0 0x1000>;
                        #address-cells = <2>;
                        #size-cells = <2>;
                        #clock-cells = <1>;
                        #reset-cells = <1>;

                        scu_ic2: interrupt-controller@100 {
                                #interrupt-cells = <1>;
                                compatible = "aspeed,ast2700-scu-ic2";
                                reg = <0 0x100 0 0x8>;
                                interrupts-extended = <&intc1_5 0>;
                                interrupt-controller;
                        };

                        scu_ic3: interrupt-controller@108 {
                                #interrupt-cells = <1>;
                                compatible = "aspeed,ast2700-scu-ic3";
                                reg = <0 0x108 0 0x8>;
                                interrupts-extended = <&intc1_5 26>;
                                interrupt-controller;
                        };

                        pinctrl1: pinctrl@400 {
                                compatible = "aspeed,ast2700-soc1-pinctrl";
                                reg = <0x0 0x400 0x0 0x100>;
                        };
                };

> 
> 
> Best regards,
> Krzysztof