Message-ID: <7b3be5c104b1fe1033570f2f3e2391991b6d9d42.camel@codeconstruct.com.au>
Date: Fri, 13 Jun 2025 14:59:43 +0930
From: Andrew Jeffery <andrew@...econstruct.com.au>
To: Ryan Chen <ryan_chen@...eedtech.com>
Cc: "Rob Herring (Arm)" <robh@...nel.org>, Catalin Marinas
 <catalin.marinas@....com>, soc@...ts.linux.dev, Mo Elbadry
 <elbadrym@...gle.com>,  Arnd Bergmann <arnd@...db.de>, William Kennington
 <wak@...gle.com>, Taniya Das <quic_tdas@...cinc.com>,
 linux-kernel@...r.kernel.org, spuranik@...dia.com,  Eric Biggers
 <ebiggers@...gle.com>, Joel Stanley <joel@....id.au>,
 linux-aspeed@...ts.ozlabs.org, Will Deacon <will@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Nishanth
 Menon <nm@...com>, Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>,
 nfraprado@...labora.com,  linux-arm-kernel@...ts.infradead.org, Kuninori
 Morimoto <kuninori.morimoto.gx@...esas.com>, Rom Lemarchand
 <romlem@...gle.com>,  devicetree@...r.kernel.org, Geert Uytterhoeven
 <geert@...ux-m68k.org>,  leohu@...dia.com, Bjorn Andersson
 <bjorn.andersson@....qualcomm.com>, Yuxiao Zhang <yuxiaozhang@...gle.com>,
 dkodihalli@...dia.com, wthai@...dia.com
Subject: Re: [PATCH v0 0/5] Add initial AST2700 SoC support

On Thu, 2025-06-12 at 15:12 -0500, Rob Herring (Arm) wrote:
> 
> On Thu, 12 Jun 2025 18:09:28 +0800, Ryan Chen wrote:
> > This patch series introduces initial support for the Aspeed AST2700 SoC
> > and the AST2700 Evaluation Board (EVB) to the Linux kernel. The AST2700
> > is the 7th generation Baseboard Management Controller (BMC) SoC from Aspeed,
> > featuring improved performance, enhanced security, and expanded I/O
> > capabilities compared to previous generations.
> > 
> > The patchset includes the following changes:
> > - Device tree bindings for AST2700 boards.
> > - Addition of the AST2700 platform to the Kconfig menu.
> > - Basic device tree for the AST2700 SoC.
> > - Device tree for the AST2700-EVB.
> > - Updated defconfig to enable essential options for AST2700.
> > 
> > Ryan Chen (5):
> >   dt-bindings: arm: aspeed: Add AST2700 board compatible
> >   arm64: Kconfig: Add Aspeed SoC family (ast2700) platform option
> >   arm64: dts: aspeed: Add initial AST2700 SoC device tree
> >   arm64: dts: aspeed: Add AST2700 EVB device tree
> >   arm64: configs: Update defconfig for AST2700 platform support
> > 
> >  .../bindings/arm/aspeed/aspeed.yaml           |   5 +
> >  arch/arm64/Kconfig.platforms                  |   6 +
> >  arch/arm64/boot/dts/Makefile                  |   1 +
> >  arch/arm64/boot/dts/aspeed/Makefile           |   4 +
> >  arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi     | 380 ++++++++++++++++++
> >  arch/arm64/boot/dts/aspeed/ast2700-evb.dts    |  54 +++
> >  arch/arm64/configs/defconfig                  |   1 +
> >  7 files changed, 451 insertions(+)
> >  create mode 100644 arch/arm64/boot/dts/aspeed/Makefile
> >  create mode 100644 arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi
> >  create mode 100644 arch/arm64/boot/dts/aspeed/ast2700-evb.dts
> > 
> > --
> > 2.34.1
> > 
> > 
> > 
> 
> 
> My bot found new DTB warnings on the .dts files added or changed in this
> series.
> 
> Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
> are fixed by another series. Ultimately, it is up to the platform
> maintainer whether these warnings are acceptable or not. No need to reply
> unless the platform maintainer has comments.
> 
> If you already ran DT checks and didn't see these error(s), then
> make sure dt-schema is up to date:
> 
>   pip3 install dtschema --upgrade
> 
> 
> This patch series was applied (using b4) to base:
>  Base: attempting to guess base-commit...
>  Base: tags/v6.16-rc1 (exact match)
> 
> If this is not the correct base, please add 'base-commit' tag
> (or use b4 which does this automatically)
> 
> New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/aspeed/' for 20250612100933.3007673-1-ryan_chen@...eedtech.com:
> 
> arch/arm64/boot/dts/aspeed/ast2700-evb.dtb: serial@...33b00 (ns16550a): 'pinctrl-0' is a dependency of 'pinctrl-names'
>         from schema $id: http://devicetree.org/schemas/pinctrl/pinctrl-consumer.yaml#
> arch/arm64/boot/dts/aspeed/ast2700-evb.dtb: interrupt-controller@100 (aspeed,ast2700-intc-ic): interrupts-extended: [[6, 0, 3844]] is too short
>         from schema $id: http://devicetree.org/schemas/interrupt-controller/aspeed,ast2700-intc.yaml#
> arch/arm64/boot/dts/aspeed/ast2700-evb.dtb: interrupt-controller@110 (aspeed,ast2700-intc-ic): interrupts-extended: [[6, 1, 3844]] is too short
>         from schema $id: http://devicetree.org/schemas/interrupt-controller/aspeed,ast2700-intc.yaml#
> arch/arm64/boot/dts/aspeed/ast2700-evb.dtb: interrupt-controller@120 (aspeed,ast2700-intc-ic): interrupts-extended: [[6, 2, 3844]] is too short
>         from schema $id: http://devicetree.org/schemas/interrupt-controller/aspeed,ast2700-intc.yaml#
> arch/arm64/boot/dts/aspeed/ast2700-evb.dtb: interrupt-controller@130 (aspeed,ast2700-intc-ic): interrupts-extended: [[6, 3, 3844]] is too short
>         from schema $id: http://devicetree.org/schemas/interrupt-controller/aspeed,ast2700-intc.yaml#
> arch/arm64/boot/dts/aspeed/ast2700-evb.dtb: interrupt-controller@140 (aspeed,ast2700-intc-ic): interrupts-extended: [[6, 4, 3844]] is too short
>         from schema $id: http://devicetree.org/schemas/interrupt-controller/aspeed,ast2700-intc.yaml#
> arch/arm64/boot/dts/aspeed/ast2700-evb.dtb: interrupt-controller@150 (aspeed,ast2700-intc-ic): interrupts-extended: [[6, 5, 3844]] is too short
>         from schema $id: http://devicetree.org/schemas/interrupt-controller/aspeed,ast2700-intc.yaml#
> 

To draw a line in the sand here: while the existing Aspeed devicetrees
(AST2600 and below) produce warnings, I won't accept devicetree patches
for the AST2700 and related boards unless they are warning-free.

Please make sure to test with the dt_binding_check and dtbs_check
targets (or equivalent) before sending your patches.

Andrew

Powered by blists - more mailing lists