linux-kernel - Re: [PATCH v4 1/2] iio: imu: inv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aEvhZiXHLLIRe41-@smile.fi.intel.com>
Date: Fri, 13 Jun 2025 11:29:26 +0300
From: Andy Shevchenko <andriy.shevchenko@...el.com>
To: jean-baptiste.maneyrol@....com
Cc: Jonathan Cameron <jic23@...nel.org>,
	Lars-Peter Clausen <lars@...afoo.de>,
	David Lechner <dlechner@...libre.com>,
	Nuno Sá <nuno.sa@...log.com>,
	Andy Shevchenko <andy@...nel.org>, linux-iio@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 1/2] iio: imu: inv_icm42600: add WoM support

On Fri, Jun 13, 2025 at 09:34:26AM +0200, Jean-Baptiste Maneyrol via B4 Relay wrote:
> 
> Add WoM as accel roc rising x|y|z event.

...

> +	if (sleep_ms)
> +		msleep(sleep_ms);

I still wonder if we can get rid of the conditional here.
Would the

	fsleep(sleep_ms * USEC_PER_MSEC)

actually work as expected?

Ditto for other case(s) like this.

...

Overall, looking to this patch again, I think it would be better to prepend it
by replacing *int*_t types by the respective uXX ones. Because in this patch
we add dozens of new ones which increases an unneeded churn in the future.

-- 
With Best Regards,
Andy Shevchenko