linux-kernel - Re: [PATCH v4 2/2] iio: imu: inv_icm42600: add wakeup functionality for Wake-on-Motion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aEvh2My32K9us0Tc@smile.fi.intel.com>
Date: Fri, 13 Jun 2025 11:31:20 +0300
From: Andy Shevchenko <andriy.shevchenko@...el.com>
To: jean-baptiste.maneyrol@....com
Cc: Jonathan Cameron <jic23@...nel.org>,
	Lars-Peter Clausen <lars@...afoo.de>,
	David Lechner <dlechner@...libre.com>,
	Nuno Sá <nuno.sa@...log.com>,
	Andy Shevchenko <andy@...nel.org>, linux-iio@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 2/2] iio: imu: inv_icm42600: add wakeup functionality
 for Wake-on-Motion

On Fri, Jun 13, 2025 at 09:34:27AM +0200, Jean-Baptiste Maneyrol via B4 Relay wrote:
> From: Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@....com>
> 
> When Wake-on-Motion is on, enable system wakeup and keep the chip on
> for waking up the system with an interrupt.

...

> +	/* accel events are wakeup capable */
> +	devm_device_init_wakeup(&indio_dev->dev);

No checking for return code? Why is it okay? This needs a really good comment,
and even better a (info / debug) message when it fails if it's not a fatal
error.

-- 
With Best Regards,
Andy Shevchenko