linux-kernel - Re: [PATCH v4 2/2] iio: imu: inv_icm42600: add wakeup functionality for Wake-on-Motion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <FR3P281MB1757C7DAF6FCF90E117AF45DCE77A@FR3P281MB1757.DEUP281.PROD.OUTLOOK.COM>
Date: Fri, 13 Jun 2025 11:42:57 +0000
From: Jean-Baptiste Maneyrol <Jean-Baptiste.Maneyrol@....com>
To: Andy Shevchenko <andriy.shevchenko@...el.com>
CC: Jonathan Cameron <jic23@...nel.org>, Lars-Peter Clausen <lars@...afoo.de>,
        David Lechner <dlechner@...libre.com>,
        Nuno Sá
	<nuno.sa@...log.com>,
        Andy Shevchenko <andy@...nel.org>,
        "linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4 2/2] iio: imu: inv_icm42600: add wakeup functionality
 for Wake-on-Motion

>
>________________________________________
>From: Andy Shevchenko <andriy.shevchenko@...el.com>
>Sent: Friday, June 13, 2025 10:31
>To: Jean-Baptiste Maneyrol <Jean-Baptiste.Maneyrol@....com>
>Cc: Jonathan Cameron <jic23@...nel.org>; Lars-Peter Clausen <lars@...afoo.de>; David Lechner <dlechner@...libre.com>; Nuno Sá <nuno.sa@...log.com>; Andy Shevchenko <andy@...nel.org>; linux-iio@...r.kernel.org <linux-iio@...r.kernel.org>; linux-kernel@...r.kernel.org <linux-kernel@...r.kernel.org>
>Subject: Re: [PATCH v4 2/2] iio: imu: inv_icm42600: add wakeup functionality for Wake-on-Motion
> 
>This Message Is From an External Sender
>This message came from outside your organization.
> 
>On Fri, Jun 13, 2025 at 09:34:27AM +0200, Jean-Baptiste Maneyrol via B4 Relay wrote:
>> From: Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@....com>
>> 
>> When Wake-on-Motion is on, enable system wakeup and keep the chip on
>> for waking up the system with an interrupt.
>
>...
>
>> +	/* accel events are wakeup capable */
>> +	devm_device_init_wakeup(&indio_dev->dev);
>
>No checking for return code? Why is it okay? This needs a really good comment,
>and even better a (info / debug) message when it fails if it's not a fatal
>error.

Sorry, just forgot. I will add it in v5.

>
>-- 
>With Best Regards,
>Andy Shevchenko
>
>
>