linux-kernel - Re: [PATCH v8 0/9] More Rust bindings for device property reads

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aEvmRmQwX7Vb8Y_3@pollux>
Date: Fri, 13 Jun 2025 10:50:14 +0200
From: Danilo Krummrich <dakr@...nel.org>
To: Remo Senekowitsch <remo@...nzli.dev>
Cc: Rob Herring <robh@...nel.org>, Saravana Kannan <saravanak@...gle.com>,
	Miguel Ojeda <ojeda@...nel.org>,
	Alex Gaynor <alex.gaynor@...il.com>,
	Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>,
	Björn Roy Baron <bjorn3_gh@...tonmail.com>,
	Benno Lossin <lossin@...nel.org>,
	Andreas Hindborg <a.hindborg@...nel.org>,
	Alice Ryhl <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"Rafael J. Wysocki" <rafael@...nel.org>,
	Dirk Behme <dirk.behme@...bosch.com>, linux-kernel@...r.kernel.org,
	devicetree@...r.kernel.org, rust-for-linux@...r.kernel.org
Subject: Re: [PATCH v8 0/9] More Rust bindings for device property reads

On Fri, Jun 13, 2025 at 09:45:47AM +0200, Remo Senekowitsch wrote:
> On Fri Jun 13, 2025 at 1:31 AM CEST, Danilo Krummrich wrote:
> > On Wed, Jun 11, 2025 at 12:28:59PM +0200, Remo Senekowitsch wrote:
> >> Remo Senekowitsch (9):
> >>   rust: device: Create FwNode abstraction for accessing device
> >>     properties
> >>   rust: device: Enable accessing the FwNode of a Device
> >>   rust: device: Move property_present() to FwNode
> >>   rust: device: Enable printing fwnode name and path
> >>   rust: device: Introduce PropertyGuard
> >>   rust: device: Implement accessors for firmware properties
> >>   samples: rust: platform: Add property read examples
> >
> > Applied to driver-core-testing, thanks!
> >
> > Once the patches passed 0-day testing they will be merged into driver-core-next.
> >
> >>   rust: device: Add child accessor and iterator
> >>   rust: device: Add property_get_reference_args
> >
> > I did drop those two patches for now, because:
> >
> >   (1) They're basically dead code.
> >
> >   (2) It seems that FwNode::property_get_reference_args() leaks a struct
> >       fwnode_handle reference. property_get_reference_args() explicitly says
> >       that the caller is responsible "for calling fwnode_handle_put() on the
> >       returned @args->fwnode pointer", which doesn't seem to happen.
> >
> > Can you please fix the leak and resend those two patches with an additional one
> > that adds a sample usage of the introduced methods to the platform sample
> > driver?
> 
> Alright, thanks. I suppose that should be a new patch series, with a new
> title and starting at v1 ..?

Yes, that's fine. Please make sure to mention that it's a follow-up of this
series (ideally with a link).