linux-kernel - Re: [PATCH v2 1/2] dt-bindings: fpga: Also describe clock for gpio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <712b690d-2fcf-486e-87a1-17e2354d371f@amd.com>
Date: Fri, 13 Jun 2025 12:52:46 +0200
From: Michal Simek <michal.simek@....com>
To: Xu Yilun <yilun.xu@...ux.intel.com>
Cc: linux-kernel@...r.kernel.org, monstr@...str.eu, michal.simek@...inx.com,
 git@...inx.com, Conor Dooley <conor+dt@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Moritz Fischer <mdf@...nel.org>,
 Rob Herring <robh@...nel.org>, Tom Rix <trix@...hat.com>,
 Wu Hao <hao.wu@...el.com>, Xu Yilun <yilun.xu@...el.com>,
 "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
 <devicetree@...r.kernel.org>,
 "open list:FPGA MANAGER FRAMEWORK" <linux-fpga@...r.kernel.org>
Subject: Re: [PATCH v2 1/2] dt-bindings: fpga: Also describe clock for gpio



On 6/13/25 12:44, Xu Yilun wrote:
> On Fri, Jun 13, 2025 at 12:12:52PM +0200, Michal Simek wrote:
>> Axi gpio is going to have clocks as required property that's why it should
>> be also described in bindings which are using axi gpio node.
>>
>> Signed-off-by: Michal Simek <michal.simek@....com>
>> ---
>>
>> Changes in v2:
>> - New patch to fix reported as issue by the second patch
>> - https://lore.kernel.org/r/174954437576.4177094.15371626866789542129.robh@kernel.org
>>
>>   Documentation/devicetree/bindings/fpga/fpga-region.yaml | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/fpga/fpga-region.yaml b/Documentation/devicetree/bindings/fpga/fpga-region.yaml
>> index 77554885a6c4..7d2d3b7aa4b7 100644
>> --- a/Documentation/devicetree/bindings/fpga/fpga-region.yaml
>> +++ b/Documentation/devicetree/bindings/fpga/fpga-region.yaml
>> @@ -316,6 +316,7 @@ examples:
>>           reg = <0x40000000 0x10000>;
>>           gpio-controller;
>>           #gpio-cells = <2>;
>> +        clocks = <&clk>;
> 
> This file is mainly for fpga-region bindings. So I don't think we have
> to strictly align with the example IP block binding every time it has
> an update.

But Rob's script are reporting issue if they are not. Please take a look at link 
above.

M