linux-kernel - Re: [PATCH] ASoC: wm8524: Remove the constraints of rate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <db0f3982-b99e-4d90-8c28-9d49c3c5e478@sirena.org.uk>
Date: Fri, 13 Jun 2025 12:21:10 +0100
From: Mark Brown <broonie@...nel.org>
To: Shengjiu Wang <shengjiu.wang@....com>
Cc: lgirdwood@...il.com, perex@...ex.cz, tiwai@...e.com,
	patches@...nsource.cirrus.com, linux-sound@...r.kernel.org,
	linux-kernel@...r.kernel.org, shengjiu.wang@...il.com
Subject: Re: [PATCH] ASoC: wm8524: Remove the constraints of rate

On Fri, Jun 13, 2025 at 11:52:16AM +0800, Shengjiu Wang wrote:

> WM8524 is a codec which can only work in slave mode, the bit clock and
> frame sync clock are from cpu dai, if there is any constraint, the
> constraint should be from cpu dai, no need to add constraint in codec
> side.

No, there is a need here - the constraint is enforcing that the ratio
between the MCLK and sample rate is within spec which is a common
requirement for audio performance.  

> On the other hand, with the constraint of rate in codec requires the
> sysclk to be fixed, which brings unnecessary limitations on sound card
> usage.

A common pattern is to only enforce constraints once a sysclk is
configured.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)