linux-kernel - Re: [PATCH] ASoC: wm8524: Remove the constraints of rate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAA+D8APtPr-_m0nGnQqQu50MFsWCn-C6mBOc_ZWE2ggmUtFftw@mail.gmail.com>
Date: Tue, 17 Jun 2025 11:10:46 +0800
From: Shengjiu Wang <shengjiu.wang@...il.com>
To: Mark Brown <broonie@...nel.org>
Cc: Shengjiu Wang <shengjiu.wang@....com>, lgirdwood@...il.com, perex@...ex.cz, 
	tiwai@...e.com, patches@...nsource.cirrus.com, linux-sound@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: wm8524: Remove the constraints of rate

On Fri, Jun 13, 2025 at 7:21 PM Mark Brown <broonie@...nel.org> wrote:
>
> On Fri, Jun 13, 2025 at 11:52:16AM +0800, Shengjiu Wang wrote:
>
> > WM8524 is a codec which can only work in slave mode, the bit clock and
> > frame sync clock are from cpu dai, if there is any constraint, the
> > constraint should be from cpu dai, no need to add constraint in codec
> > side.
>
> No, there is a need here - the constraint is enforcing that the ratio
> between the MCLK and sample rate is within spec which is a common
> requirement for audio performance.
>
> > On the other hand, with the constraint of rate in codec requires the
> > sysclk to be fixed, which brings unnecessary limitations on sound card
> > usage.
>
> A common pattern is to only enforce constraints once a sysclk is
> configured.

Thanks for the comments, I will update the commit to only enable
constraints when sysclk is available.

Best regards
Shengjiu Wang