linux-kernel - Re: [PATCH 5/5] ARM: dts: qcom: add device tree for Sony Xperia SP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <39a7153e-1a4f-4dfc-a190-3b3370646d47@smankusors.com>
Date: Sat, 14 Jun 2025 20:46:41 +0000 (UTC)
From: Antony Kurniawan Soemardi <linux@...nkusors.com>
To: Konrad Dybcio <konrad.dybcio@....qualcomm.com>,
 Bjorn Andersson <andersson@...nel.org>,
 Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>
Cc: linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, Max Shevchenko <wctrl@...ton.me>,
 Rudraksha Gupta <guptarud@...il.com>
Subject: Re: [PATCH 5/5] ARM: dts: qcom: add device tree for Sony Xperia SP

On 6/15/2025 1:36 AM, Konrad Dybcio wrote:
> IIUC (and that's a 10yo range memory), SP had some eyebrow-rising boot
> flow (some partitions were non-standard?) - could you please add a
> paragraph about it in the commit message if that's the case, and maybe
> include a short how-to on booting the thing?
Is it acceptable to provide the pmOS wiki link in the commit message 
instead?
https://wiki.postmarketos.org/wiki/Sony_Xperia_SP_(sony-huashan)

Or should I include a paragraph explaining it? It might be lengthy since
I'd need to add download links for the mkelf and the RPM blob.

But in a nutshell, concatenate the kernel with the DTB, create a SonyELF
boot image, and then boot it.

> As for the code.. I don't really have comments other than please
> keep a \n before 'status', other things seem rather in order.. If
> the dt checker doesn't complain, I don't see any logical wrongs
>
> Konrad
Thanks for the review. Going to sent the second version later.

As for the other things... well in my opinion it's not kinda in order,
especially the nodes ordering at qcom-msm8960.dtsi. Welp that might be
a separate patch I think...


Thanks,
Antony K. S.