linux-kernel - Re: [PATCH v3] audit,module: restore audit logging in load failure case

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e12739f9-bb54-4e9d-b70c-f4b5f99a7920@suse.com>
Date: Mon, 16 Jun 2025 15:55:45 +0200
From: Petr Pavlu <petr.pavlu@...e.com>
To: Richard Guy Briggs <rgb@...hat.com>
Cc: Paul Moore <paul@...l-moore.com>, Eric Paris <eparis@...isplace.org>,
 Steve Grubb <sgrubb@...hat.com>,
 Linux-Audit Mailing List <linux-audit@...ts.linux-audit.osci.io>,
 LKML <linux-kernel@...r.kernel.org>, linux-modules@...r.kernel.org,
 Linux Kernel Audit Mailing List <audit@...r.kernel.org>
Subject: Re: [PATCH v3] audit,module: restore audit logging in load failure
 case

On 6/13/25 9:58 PM, Richard Guy Briggs wrote:
> The move of the module sanity check to earlier skipped the audit logging
> call in the case of failure and to a place where the previously used
> context is unavailable.
> 
> Add an audit logging call for the module loading failure case and get
> the module name when possible.
> 
> Link: https://issues.redhat.com/browse/RHEL-52839
> Fixes: 02da2cbab452 ("module: move check_modinfo() early to early_mod_check()")
> Signed-off-by: Richard Guy Briggs <rgb@...hat.com>

Looks ok to me from the modules perspective.

Reviewed-by: Petr Pavlu <petr.pavlu@...e.com>

-- 
Thanks,
Petr