linux-kernel - Re: [PATCH v3] audit,module: restore audit logging in load failure case

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <baa9721a34d995cbcc9f7db5c9eba531@paul-moore.com>
Date: Mon, 16 Jun 2025 17:00:05 -0400
From: Paul Moore <paul@...l-moore.com>
To: Richard Guy Briggs <rgb@...hat.com>, Linux-Audit Mailing List <linux-audit@...ts.linux-audit.osci.io>, LKML <linux-kernel@...r.kernel.org>, linux-modules@...r.kernel.org, Linux Kernel Audit Mailing List <audit@...r.kernel.org>
Cc: Eric Paris <eparis@...isplace.org>, Steve Grubb <sgrubb@...hat.com>, Richard Guy Briggs <rgb@...hat.com>
Subject: Re: [PATCH v3] audit,module: restore audit logging in load failure  case

On Jun 13, 2025 Richard Guy Briggs <rgb@...hat.com> wrote:
> 
> The move of the module sanity check to earlier skipped the audit logging
> call in the case of failure and to a place where the previously used
> context is unavailable.
> 
> Add an audit logging call for the module loading failure case and get
> the module name when possible.
> 
> Link: https://issues.redhat.com/browse/RHEL-52839
> Fixes: 02da2cbab452 ("module: move check_modinfo() early to early_mod_check()")
> Signed-off-by: Richard Guy Briggs <rgb@...hat.com>
> Reviewed-by: Petr Pavlu <petr.pavlu@...e.com>
> ---
> Changelog:
> v2
> - use info->name for both audit_log_kern_module() calls and add const
> v3
> - use "?" rather than "(unavailable)" for consistency with other records
> ---
>  include/linux/audit.h | 9 ++++-----
>  kernel/audit.h        | 2 +-
>  kernel/auditsc.c      | 2 +-
>  kernel/module/main.c  | 6 ++++--
>  4 files changed, 10 insertions(+), 9 deletions(-)

Merged into audit/dev, thanks!

--
paul-moore.com