linux-kernel - Re: [PATCH] dmaengine: Add NULL check in lpc32xx_dmamux

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <335bf854-1a73-4370-93f4-77e9fd3febca@mleia.com>
Date: Mon, 16 Jun 2025 18:26:00 +0300
From: Vladimir Zapolskiy <vz@...ia.com>
To: Charles Han <hanchunchao@...pur.com>, vkoul@...nel.org,
 piotr.wojtaszczyk@...esys.com
Cc: dmaengine@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dmaengine: Add NULL check in lpc32xx_dmamux_reserve()

Hi Charles,

On 6/16/25 13:46, Charles Han wrote:
> The function of_find_device_by_node() may return NULL if the device
> node cannot be found or if CONFIG_OF is not defined, dereferencing

please see my comments provided for lpc18xx-dmamux.c driver, all of
them are applicable here as well.

There is no problem to be fixed, the change also shall be dropped
in my opinion.

> it without NULL check may lead to NULL dereference.
> Add a check to verify whether the return value is NULL.
> 
> Fixes: 5d318b595982 ("dmaengine: Add dma router for pl08x in LPC32XX SoC")
> Signed-off-by: Charles Han <hanchunchao@...pur.com>

--
Best wishes,
Vladimir