linux-kernel - Re: [PATCH net-next v13 02/13] net: pse-pd: Add support for reporting events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250616093048.0a0ff1aa@kernel.org>
Date: Mon, 16 Jun 2025 09:30:48 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Kory Maincent <kory.maincent@...tlin.com>
Cc: Andrew Lunn <andrew@...n.ch>, Oleksij Rempel <o.rempel@...gutronix.de>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Jonathan Corbet
 <corbet@....net>, Donald Hunter <donald.hunter@...il.com>, Rob Herring
 <robh@...nel.org>, Andrew Lunn <andrew+netdev@...n.ch>, Simon Horman
 <horms@...nel.org>, Heiner Kallweit <hkallweit1@...il.com>, Russell King
 <linux@...linux.org.uk>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor
 Dooley <conor+dt@...nel.org>, Liam Girdwood <lgirdwood@...il.com>, Mark
 Brown <broonie@...nel.org>, Thomas Petazzoni
 <thomas.petazzoni@...tlin.com>, netdev@...r.kernel.org,
 linux-doc@...r.kernel.org, Kyle Swenson <kyle.swenson@....tech>, Dent
 Project <dentproject@...uxfoundation.org>, kernel@...gutronix.de, Maxime
 Chevallier <maxime.chevallier@...tlin.com>, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v13 02/13] net: pse-pd: Add support for
 reporting events

On Mon, 16 Jun 2025 14:10:12 +0200 Kory Maincent wrote:
> psec = pse_control_find_by_id(pcdev, i, &tracker);
> rtnl_lock();
> if (psec && psec->attached_phydev &&
>     psec->attached_phydev->attached_dev)
> 	ethnl_pse_send_ntf(psec->attached_phydev->attached_dev, notifs,
> 			   &extack);
> rtnl_unlock();
> pse_control_put(psec);

You can add another helper for clarity:

pse_control_get_netdev()
{
	ASSERT_RTNL();

	if (!psec || !psec->attached_phydev)
		return NULL
	return psec->attached_phydev->attached_dev;
}

psec = pse_control_find_by_id(pcdev, i, &tracker);
rtnl_lock();
netdev = pse_control_get_netdev(psec);
if (netdev)
	ethnl_pse_send_ntf(netdev, notifs, &extack);
rtnl_unlock();
pse_control_put(psec);

?