linux-kernel - Re: [PATCH net-next v13 07/13] net: pse-pd: Add support for budget evaluation strategies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250616095658.323847a9@kernel.org>
Date: Mon, 16 Jun 2025 09:56:58 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Kory Maincent <kory.maincent@...tlin.com>
Cc: Andrew Lunn <andrew@...n.ch>, Oleksij Rempel <o.rempel@...gutronix.de>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Jonathan Corbet
 <corbet@....net>, Donald Hunter <donald.hunter@...il.com>, Rob Herring
 <robh@...nel.org>, Andrew Lunn <andrew+netdev@...n.ch>, Simon Horman
 <horms@...nel.org>, Heiner Kallweit <hkallweit1@...il.com>, Russell King
 <linux@...linux.org.uk>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor
 Dooley <conor+dt@...nel.org>, Liam Girdwood <lgirdwood@...il.com>, Mark
 Brown <broonie@...nel.org>, Thomas Petazzoni
 <thomas.petazzoni@...tlin.com>, netdev@...r.kernel.org,
 linux-doc@...r.kernel.org, Kyle Swenson <kyle.swenson@....tech>, Dent
 Project <dentproject@...uxfoundation.org>, kernel@...gutronix.de, Maxime
 Chevallier <maxime.chevallier@...tlin.com>, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v13 07/13] net: pse-pd: Add support for budget
 evaluation strategies

On Mon, 16 Jun 2025 15:14:37 +0200 Kory Maincent wrote:
> > On Tue, 10 Jun 2025 10:11:41 +0200 Kory Maincent wrote:  
> > > +static bool
> > > +pse_pi_is_admin_enable_not_applied(struct pse_controller_dev *pcdev,
> > > +				   int id)    
> > 
> > the only caller of this function seems to negate the return value:
> > 
> > drivers/net/pse-pd/pse_core.c:369:              if
> > (!pse_pi_is_admin_enable_not_applied(pcdev, i))
> > 
> > let's avoid the double negation ?  
> 
> I thought it was better for comprehension.
> If we inverse the behavior we would have a function name like that:
> pse_pi_is_admin_disable_not_detected_or_applied()
> 
> Do you have a better proposition?

Would pse_pi_is_admin_enable_pending() work?