linux-kernel - Re: [PATCH] wifi: carl9170: do not ping device which has failed to load firmware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <70de6013-a5db-45c6-8288-e7b211a55a1e@yandex.ru>
Date: Mon, 16 Jun 2025 13:01:32 +0300
From: Dmitry Antipov <dmantipov@...dex.ru>
To: Fedor Pchelkin <pchelkin@...ras.ru>,
 Christian Lamparter <chunkeey@...il.com>
Cc: linux-wireless@...r.kernel.org,
 Christian Lamparter <chunkeey@...glemail.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] wifi: carl9170: do not ping device which has failed to
 load firmware

On 6/15/25 10:54 PM, Fedor Pchelkin wrote:

> So it looks like ar->registered being false here is a "correct" failure
> condition, i.e. it can be expected when the certain phase of the driver
> initialization fails and should be handled without any WARNs.

Looking through Documentation/process/coding-style.rst, it may be
better to use pr_warn_once() instead; anyway I would prefer leave
the final decision to the maintainer.

Dmitry