linux-kernel - Re: [PATCH v4 0/5] Add FIELD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0c0a9c7a-f36e-4500-bbea-3a22a04431b3@quicinc.com>
Date: Mon, 16 Jun 2025 18:06:36 +0800
From: Luo Jie <quic_luoj@...cinc.com>
To: Marc Zyngier <maz@...nel.org>
CC: Yury Norov <yury.norov@...il.com>,
        Rasmus Villemoes
	<linux@...musvillemoes.dk>,
        Julia Lawall <Julia.Lawall@...ia.fr>,
        "Nicolas
 Palix" <nicolas.palix@...g.fr>,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will@...nel.org>, Oliver Upton <oliver.upton@...ux.dev>,
        "Joey
 Gouly" <joey.gouly@....com>,
        Suzuki K Poulose <suzuki.poulose@....com>,
        Zenghui Yu <yuzenghui@...wei.com>, <linux-kernel@...r.kernel.org>,
        <cocci@...ia.fr>, <linux-arm-kernel@...ts.infradead.org>,
        <kvmarm@...ts.linux.dev>, <andrew@...n.ch>,
        <quic_kkumarcs@...cinc.com>, <quic_linchen@...cinc.com>,
        <quic_leiwei@...cinc.com>, <quic_suruchia@...cinc.com>,
        <quic_pavir@...cinc.com>
Subject: Re: [PATCH v4 0/5] Add FIELD_MODIFY() helper



On 6/12/2025 10:11 PM, Marc Zyngier wrote:
> On Thu, 12 Jun 2025 14:46:07 +0100,
> Luo Jie <quic_luoj@...cinc.com> wrote:
>>
>> Add the helper FIELD_MODIFY() to the FIELD_XXX family of bitfield
>> macros. It is functionally similar as xxx_replace_bits(), but adds
>> the compile time checking to catch incorrect parameter type errors.
>>
>> This series also converts the four instances of opencoded FIELD_MODIFY()
>> that are found in the core kernel files, to instead use the new
>> FIELD_MODIFY() macro. This is achieved with Coccinelle, by adding
>> the script field_modify.cocci.
>>
>> The changes are validated on IPQ9574 SoC which uses ARM64 architecture.
>>
>> Signed-off-by: Luo Jie <quic_luoj@...cinc.com>
> 
> I already indicated that the *pre-existing* set of helpers are enough
> for what we want to do, that we *already* use them for KVM/arm64, and
> that I didn't need nor want two ways to do the same thing in the same
> code base.
> 
> My opinion hasn't changed on that front, and I don't see a point in
> these patches.
> 
> 	M.
> 

OK. I will drop the ARM64 patches and only keep the coccinelle script
patch in the next version.