linux-kernel - Re: [cocci] [PATCH v4 1/5] coccinelle: misc: Add field

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3fe9e742-48ec-4b6e-9819-8e0f3e3dad0e@quicinc.com>
Date: Mon, 16 Jun 2025 18:28:25 +0800
From: Luo Jie <quic_luoj@...cinc.com>
To: Markus Elfring <Markus.Elfring@....de>, <cocci@...ia.fr>
CC: LKML <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>, <kvmarm@...ts.linux.dev>,
        Andrew Lunn
	<andrew@...n.ch>,
        Catalin Marinas <catalin.marinas@....com>,
        Joey Gouly
	<joey.gouly@....com>, Julia Lawall <Julia.Lawall@...ia.fr>,
        Kiran Kumar C.S.K
	<quic_kkumarcs@...cinc.com>,
        Lei Wei <quic_leiwei@...cinc.com>, Marc Zyngier
	<maz@...nel.org>,
        Nicolas Palix <nicolas.palix@...g.fr>,
        Oliver Upton
	<oliver.upton@...ux.dev>,
        Pavithra R <quic_pavir@...cinc.com>,
        "Rasmus
 Villemoes" <linux@...musvillemoes.dk>,
        Suruchi Agarwal
	<quic_suruchia@...cinc.com>,
        Suzuki Poulose <suzuki.poulose@....com>,
        "Will
 Deacon" <will@...nel.org>, Yury Norov <yury.norov@...il.com>,
        Zenghui Yu
	<yuzenghui@...wei.com>, <quic_linchen@...cinc.com>
Subject: Re: [cocci] [PATCH v4 1/5] coccinelle: misc: Add field_modify script



On 6/13/2025 12:48 AM, Markus Elfring wrote:
> …
>> ---
>>   scripts/coccinelle/misc/field_modify.cocci | 61 ++++++++++++++++++++++++++++++
> …
> 
> Did you overlook the addition of patch version descriptions?
> https://lore.kernel.org/all/?q=%22This+looks+like+a+new+version+of+a+previously+submitted+patch%22
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.15#n310

Thank you for highlighting this, and for the references. A brief
description of the differences in this script patch compared to
the previous (v3) version were included in the cover letter, so
a changelog was not added to the individual patch's commit message.
Hope this approach is acceptable.

I will ensure to include the reviewer in the CC list for future
submissions, as recommended in the documentation.

> 
> 
> …
>> +@ depends on context && !patch && !org && !report@
> …
> 
> I imagine that the condition selections can be simplified.
> 

I agree that the condition selections can be simplified, I will
update it to "@ depends on context@". Hope it is fine.

> 
> …
>> +@...ipt:python depends on report@
>> +p << r.p;
>> +x << r.reg;
>> +@@
>> +
>> +msg="WARNING: Consider using FIELD_MODIFY helper on %s" % (x)
>> +coccilib.report.print_report(p[0], msg)
> Do you know that a string construction can also be directly passed
> to such a function call?

I appreciate the tip. I'll update the patch to pass the formatted
string directly to the function call in the next revision.

> 
> Regards,
> Markus