linux-kernel - Re: [cocci] [PATCH v4 2/5] arm64: tlb: Convert the opencoded field modify

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <94b40ff2-9e9e-4eea-8a66-87d8976aeb70@quicinc.com>
Date: Mon, 16 Jun 2025 18:37:41 +0800
From: Luo Jie <quic_luoj@...cinc.com>
To: Markus Elfring <Markus.Elfring@....de>, <cocci@...ia.fr>
CC: LKML <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>, <kvmarm@...ts.linux.dev>,
        Andrew Lunn
	<andrew@...n.ch>,
        Catalin Marinas <catalin.marinas@....com>,
        Joey Gouly
	<joey.gouly@....com>, Julia Lawall <Julia.Lawall@...ia.fr>,
        Kiran Kumar C.S.K
	<quic_kkumarcs@...cinc.com>,
        Lei Wei <quic_leiwei@...cinc.com>, Marc Zyngier
	<maz@...nel.org>,
        Nicolas Palix <nicolas.palix@...g.fr>,
        Oliver Upton
	<oliver.upton@...ux.dev>,
        Pavithra R <quic_pavir@...cinc.com>,
        "Rasmus
 Villemoes" <linux@...musvillemoes.dk>,
        Suruchi Agarwal
	<quic_suruchia@...cinc.com>,
        Suzuki Poulose <suzuki.poulose@....com>,
        "Will
 Deacon" <will@...nel.org>, Yury Norov <yury.norov@...il.com>,
        Zenghui Yu
	<yuzenghui@...wei.com>, <quic_linchen@...cinc.com>
Subject: Re: [cocci] [PATCH v4 2/5] arm64: tlb: Convert the opencoded field
 modify



On 6/13/2025 4:15 AM, Markus Elfring wrote:
> I see further refinement possibilities for such a change description.
> 
> 
>> Replace below code with the wrapper FIELD_MODIFY(MASK, &reg, val)
>> - reg &= ~MASK;
>> - reg |= FIELD_PREP(MASK, val);
> 
> * How do you think about to omit leading minus characters?
> 
> * Subsequent blank line?
> 
> 
>> More information about semantic patching is available at
>> http://coccinelle.lip6.fr/
> 
> I suggest to omit this information here (and in similar patches).
> 
> Regards,
> Markus

Thank you for your suggestions. The current commit message was generated
by the following patch mode command:
```
make coccicheck MODE=patch 
COCCI=scripts/coccinelle/misc/field_modify.cocci V=1
```
However, as I understand, the discussion on the ARM patches (between
Russel/Marc/Yury) has concluded that the ARM arch changes may not be
adding value over the current code, so I will drop the ARM patches
in the next version.

I will review the generated message to improve the formatting as you
suggested, the next time I use it.