linux-kernel - Re: [PATCH] drivers: char: SONYPI depends on HAS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7f388a3f-6dcc-4989-9a4e-e15000069b68@infradead.org>
Date: Tue, 17 Jun 2025 11:41:22 -0700
From: Randy Dunlap <rdunlap@...radead.org>
To: Johannes Berg <johannes@...solutions.net>, linux-kernel@...r.kernel.org
Cc: Arnd Bergmann <arnd@...db.de>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Johannes Berg <johannes.berg@...el.com>, kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] drivers: char: SONYPI depends on HAS_IOPORT



On 6/6/25 12:12 AM, Johannes Berg wrote:
> From: Johannes Berg <johannes.berg@...el.com>
> 
> It already depends on X86_32, but that's also set for ARCH=um.
> Recent changes made UML no longer have IO port access since
> it's not needed, but this driver uses it. Build it only for
> HAS_IOPORT. This is pretty much the same as depending on X86,
> but on the off-chance that HAS_IOPORT will ever be optional
> on x86 HAS_IOPORT is the real prerequisite.
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202506060742.XR3HcxWA-lkp@intel.com/
> Signed-off-by: Johannes Berg <johannes.berg@...el.com>

Acked-by: Randy Dunlap <rdunlap@...radead.org>
Tested-by: Randy Dunlap <rdunlap@...radead.org>

Thanks.

> ---
>  drivers/char/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/char/Kconfig b/drivers/char/Kconfig
> index 8fb33c90482f..36295558dc85 100644
> --- a/drivers/char/Kconfig
> +++ b/drivers/char/Kconfig
> @@ -237,7 +237,7 @@ config APPLICOM
>  
>  config SONYPI
>  	tristate "Sony Vaio Programmable I/O Control Device support"
> -	depends on X86_32 && PCI && INPUT
> +	depends on X86_32 && PCI && INPUT && HAS_IOPORT
>  	depends on ACPI_EC || !ACPI
>  	help
>  	  This driver enables access to the Sony Programmable I/O Control

-- 
~Randy