linux-kernel - Re: [PATCH v3 1/2] rust: Introduce file_from

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2f0f12b6-fcff-492f-8b22-7b36ff8065ed@nvidia.com>
Date: Tue, 17 Jun 2025 13:33:47 -0700
From: John Hubbard <jhubbard@...dia.com>
To: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>,
 Boqun Feng <boqun.feng@...il.com>
Cc: linux-kernel@...r.kernel.org, rust-for-linux@...r.kernel.org,
 ojeda@...nel.org, alex.gaynor@...il.com, gary@...yguo.net,
 bjorn3_gh@...tonmail.com, benno.lossin@...ton.me, a.hindborg@...sung.com,
 aliceryhl@...gle.com, tmgross@...ch.edu, dakr@...nel.org, mingo@...hat.com,
 peterz@...radead.org, juri.lelli@...hat.com, vincent.guittot@...aro.org,
 dietmar.eggemann@....com, rostedt@...dmis.org, bsegall@...gle.com,
 mgorman@...e.de, vschneid@...hat.com, pmladek@...e.com,
 fujita.tomonori@...il.com, mingo@...nel.org
Subject: Re: [PATCH v3 1/2] rust: Introduce file_from_location()

On 6/17/25 11:22 AM, Miguel Ojeda wrote:
> On Tue, Jun 17, 2025 at 8:12 PM Boqun Feng <boqun.feng@...il.com> wrote:
>>
>> How aobut something below? (I use "" instead of `` on purpose because
>> the output variable there is a string)
> 
> Looks much better, thanks!
> 
>> You mean it should be "with an NUL terminated"? Or it should be "with
>> a `NUL` byte terminated"?
> 
> Ah, I meant that "terminated" sounded strange to me, i.e. it sounds as
> if the NUL is what is terminated. But I am not a native speaker.
> 
> I would have expected e.g. "a NUL terminated string" or variations
> like "a string terminated with a NUL" or"a string with a NUL
> termination byte", if that makes sense.


Yes, instead of this:

    "guarantees to return a string with a NUL terminated."

...you will want this:

     "guarantees to return a NUL-terminated string."

And depending on whether you prefer to speak Kernel, or R4L here,
note that the kernel normally spells this as NULL (two L's).

thanks,
John Hubbard