linux-kernel - Re: [PATCH] nvme: Fix incorrect cdw15 value in passthru error logging

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7a4d3674-53b9-4f9c-92e0-74aa1202f500@oracle.com>
Date: Tue, 17 Jun 2025 07:26:40 +0100
From: John Garry <john.g.garry@...cle.com>
To: Alok Tiwari <alok.a.tiwari@...cle.com>, kbusch@...nel.org, axboe@...nel.dk,
        hch@....d, sagi@...mberg.me, linux-nvme@...ts.infradead.org
Cc: linux-kernel@...r.kernel.org, darren.kenny@...cle.com
Subject: Re: [PATCH] nvme: Fix incorrect cdw15 value in passthru error logging

On 16/06/2025 19:19, Alok Tiwari wrote:
> Fix an error in nvme_log_err_passthru() where cdw14 was incorrectly
> printed twice instead of cdw15. This fix ensures accurate logging of
> the full passthrough command payload.
> 
> Fixes: 9f079dda1433 ("nvme: allow passthru cmd error logging")
> Signed-off-by: Alok Tiwari <alok.a.tiwari@...cle.com>
> ---
> Is it ok to keep Fixes tag for this fix?
> ---
>   drivers/nvme/host/core.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
> index 92697f98c601..f3e07cb92385 100644
> --- a/drivers/nvme/host/core.c
> +++ b/drivers/nvme/host/core.c
> @@ -386,7 +386,7 @@ static void nvme_log_err_passthru(struct request *req)
>   		nr->cmd->common.cdw12,
>   		nr->cmd->common.cdw13,
>   		nr->cmd->common.cdw14,
> -		nr->cmd->common.cdw14);
> +		nr->cmd->common.cdw15);

Apart from the fix, any reason not to use le32_to_cpu() when getting 
these values? AFAICS, they are __le32 type

>   }
>   
>   enum nvme_disposition {