linux-kernel - RE: [RESEND PATCH 1/2] arm64: dts: socfpga: agilex5: Add SMMU-V3-PMCG nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <DM8PR03MB6230323BB6CEA92F41193269F573A@DM8PR03MB6230.namprd03.prod.outlook.com>
Date: Tue, 17 Jun 2025 08:56:25 +0000
From: "Ng, Adrian Ho Yin" <adrian.ho.yin.ng@...era.com>
To: Krzysztof Kozlowski <krzk@...nel.org>, "dinguyen@...nel.org"
	<dinguyen@...nel.org>, "robh@...nel.org" <robh@...nel.org>,
	"krzk+dt@...nel.org" <krzk+dt@...nel.org>, "conor+dt@...nel.org"
	<conor+dt@...nel.org>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
CC: Matthew Gerlach <matthew.gerlach@...rera.com>
Subject: RE: [RESEND PATCH 1/2] arm64: dts: socfpga: agilex5: Add SMMU-V3-PMCG
 nodes

> > diff --git a/arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi
> > b/arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi
> > index 7d9394a04302..06920de87a41 100644
> > --- a/arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi
> > +++ b/arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi
> > @@ -133,6 +133,68 @@ usbphy0: usbphy {
> >  		compatible = "usb-nop-xceiv";
> >  	};
> >
> > +	pmu0: pmu {
> > +		compatible = "arm,armv8-pmuv3";
> > +		interrupt-parent = <&intc>;
> > +		interrupts = <GIC_PPI 7 IRQ_TYPE_LEVEL_LOW>;
> > +	};
> > +
> > +	pmu0_tcu: pmu@...02000 {
> 
> 
> It does not look like you tested the DTS against bindings. Please run `make
> dtbs_check W=1` (see Documentation/devicetree/bindings/writing-
> schema.rst or https://www.linaro.org/blog/tips-and-tricks-for-validating-
> devicetree-sources-with-the-devicetree-schema/
> for instructions).
> Maybe you need to update your dtschema and yamllint. Don't rely on distro
> packages for dtschema and be sure you are using the latest released
> dtschema.
> 
> Or... if it passes still obviously mixes MMIO and non-MMIO nodes. MMIO
> nodes go into soc@0.
> 
Hi Krzysztof,

The changes in the DTS were tested against the updated dtschema and yamllint and it was passing.
I will move the MMIO nodes into soc@0 in V2 submission.