[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <9c85755a8aff6e6f8a5548f0b5e758dce7d6353e.camel@codeconstruct.com.au>
Date: Wed, 18 Jun 2025 12:26:45 +0930
From: Andrew Jeffery <andrew@...econstruct.com.au>
To: Cool Lee <cool_lee@...eedtech.com>, adrian.hunter@...el.com,
ulf.hansson@...aro.org, joel@....id.au, p.zabel@...gutronix.de,
linux-aspeed@...ts.ozlabs.org, openbmc@...ts.ozlabs.org,
linux-mmc@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 7/8] mmc: sdhci-of-aspeed: Remove timing phase
On Sun, 2025-06-15 at 11:58 +0800, Cool Lee wrote:
> The timing phase is no more needed since the auto tuning is applied.
>
I feel this is unwise: we're now ignoring constraints set in the
devicetree. Auto-tuning is fine, but I think that should be a feature
that new platforms can exploit by default. Older platforms that do
specify the phase values via the devicetree can be converted at the
leisure of their maintainers (by removing the phase properties).
Support needs to remain in the driver until there are no (aspeed-based)
devicetrees specifying the phases.
Andrew
Powered by blists - more mailing lists