linux-kernel - Re: [PATCH 2/2] gpio: mmio: don't use legacy GPIO chip setters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b522222d-f16d-4093-8a63-fc8195ae4c4c@sirena.org.uk>
Date: Wed, 18 Jun 2025 17:53:27 +0100
From: Mark Brown <broonie@...nel.org>
To: Bartosz Golaszewski <brgl@...ev.pl>
Cc: Klara Modin <klarasmodin@...il.com>,
	Avi Fishman <avifishman70@...il.com>,
	Tomer Maimon <tmaimon77@...il.com>,
	Tali Perry <tali.perry1@...il.com>,
	Patrick Venture <venture@...gle.com>, Nancy Yuen <yuenn@...gle.com>,
	Benjamin Fair <benjaminfair@...gle.com>,
	Linus Walleij <linus.walleij@...aro.org>, openbmc@...ts.ozlabs.org,
	linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
	Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
Subject: Re: [PATCH 2/2] gpio: mmio: don't use legacy GPIO chip setters

On Wed, Jun 18, 2025 at 03:02:07PM +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
> 
> We've converted this driver to using the new GPIO line value setters but
> missed the instances where the legacy callback is accessed directly using
> the function pointer. This will lead to a NULL-pointer dereference as
> this pointer is no longer populated. The issue needs fixing locally as
> well as in the already converted previously users of gpio-mmio.

Tested-by: Mark Brown <broonie@...nel.org>

This fixes boot breakage in -next on at least the i.MX6 platforms I
have, I'm also seeing similar issues on a bunch of i.MX8 systems which
look to be due to the same issue but didn't verify them yet.  I'll let
you know if it looks like something else.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)