linux-kernel - Re: [PATCH 3/8] powerpc/pseries/eeh: Export eeh_unfreeze_pe() and eeh

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <596516884.1310632.1750265758190.JavaMail.zimbra@raptorengineeringinc.com>
Date: Wed, 18 Jun 2025 11:55:58 -0500 (CDT)
From: Timothy Pearson <tpearson@...torengineering.com>
To: Christoph Hellwig <hch@...radead.org>
Cc: linuxppc-dev <linuxppc-dev@...ts.ozlabs.org>, 
	linux-kernel <linux-kernel@...r.kernel.org>, 
	linux-pci <linux-pci@...r.kernel.org>, 
	Madhavan Srinivasan <maddy@...ux.ibm.com>, 
	Michael Ellerman <mpe@...erman.id.au>, 
	christophe leroy <christophe.leroy@...roup.eu>, 
	Naveen N Rao <naveen@...nel.org>, 
	Bjorn Helgaas <bhelgaas@...gle.com>, 
	Shawn Anastasio <sanastasio@...torengineering.com>
Subject: Re: [PATCH 3/8] powerpc/pseries/eeh: Export eeh_unfreeze_pe() and
 eeh_ops



----- Original Message -----
> From: "Timothy Pearson" <tpearson@...torengineeringinc.com>
> To: "Christoph Hellwig" <hch@...radead.org>
> Cc: "linuxppc-dev" <linuxppc-dev@...ts.ozlabs.org>, "linux-kernel" <linux-kernel@...r.kernel.org>, "linux-pci"
> <linux-pci@...r.kernel.org>, "Madhavan Srinivasan" <maddy@...ux.ibm.com>, "Michael Ellerman" <mpe@...erman.id.au>,
> "christophe leroy" <christophe.leroy@...roup.eu>, "Naveen N Rao" <naveen@...nel.org>, "Bjorn Helgaas"
> <bhelgaas@...gle.com>, "Shawn Anastasio" <sanastasio@...torengineering.com>
> Sent: Wednesday, June 18, 2025 11:10:02 AM
> Subject: Re: [PATCH 3/8] powerpc/pseries/eeh: Export eeh_unfreeze_pe() and eeh_ops

> ----- Original Message -----
>> From: "Christoph Hellwig" <hch@...radead.org>
>> To: "Timothy Pearson" <tpearson@...torengineering.com>
>> Cc: "linuxppc-dev" <linuxppc-dev@...ts.ozlabs.org>, "linux-kernel"
>> <linux-kernel@...r.kernel.org>, "linux-pci"
>> <linux-pci@...r.kernel.org>, "Madhavan Srinivasan" <maddy@...ux.ibm.com>,
>> "Michael Ellerman" <mpe@...erman.id.au>,
>> "christophe leroy" <christophe.leroy@...roup.eu>, "Naveen N Rao"
>> <naveen@...nel.org>, "Bjorn Helgaas"
>> <bhelgaas@...gle.com>, "Shawn Anastasio" <sanastasio@...torengineering.com>
>> Sent: Wednesday, June 18, 2025 12:38:56 AM
>> Subject: Re: [PATCH 3/8] powerpc/pseries/eeh: Export eeh_unfreeze_pe() and
>> eeh_ops
> 
>> On Tue, Jun 17, 2025 at 11:22:39PM -0500, Timothy Pearson wrote:
>>>  /* Platform dependent EEH operations */
>>>  struct eeh_ops *eeh_ops = NULL;
>>> +EXPORT_SYMBOL(eeh_ops);
>> 
>> Exporting ops vectors is generally a really bad idea.  Please build a
>> proper abstraction instead.
>> 
>> And use EXPORT_SYMBOL_GPL for any kind of low-level API.
> 
> Fair enough.  I'll add a properly exported method for PE get_state() and update
> the series in the next couple of days.

Somehow I completely missed eeh_pe_get_state() the first time around.  I don't need to change the API, v2 incoming now.