linux-kernel - Re: [PATCH] usb: host: xhci-plat: fix incorrect type for of_match variable in xhci_plat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2025061804-existing-taking-1f9c@gregkh>
Date: Wed, 18 Jun 2025 08:02:38 +0200
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: pip-izony <eeodqql09@...il.com>
Cc: Mathias Nyman <mathias.nyman@...el.com>, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb: host: xhci-plat: fix incorrect type for of_match
 variable in xhci_plat_probe()

On Tue, Jun 17, 2025 at 04:45:00PM -0400, pip-izony wrote:
> The variable `of_match` was incorrectly declared as a `bool`.
> It is assigned the return value of of_match_device(), which is a pointer of
> type `const struct of_device_id *`.
> 
> Signed-off-by: pip-izony <eeodqql09@...il.com>

We need a real name here, please.

Also, what commit id does this fix?

And finally, how is this even building if the type is wrong?

confused,

greg k-h