linux-kernel - Re: [PATCH v2 1/2] dt-bindings: i3c: Add adi-i3c-master

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <qg2l6wfzaquxepeubxgrp2xdbdsfqam3vpzc75sar66jhpc3zn@wi3yk75lebo2>
Date: Wed, 18 Jun 2025 09:10:01 +0200
From: Jorge Marques <gastmaier@...il.com>
To: Conor Dooley <conor@...nel.org>
Cc: Jorge Marques <jorge.marques@...log.com>, 
	Alexandre Belloni <alexandre.belloni@...tlin.com>, Frank Li <Frank.Li@....com>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	linux-i3c@...ts.infradead.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: i3c: Add adi-i3c-master

On Tue, Jun 17, 2025 at 04:47:58PM +0100, Conor Dooley wrote:
> On Tue, Jun 17, 2025 at 04:50:43PM +0200, Jorge Marques wrote:
> > On Fri, Jun 06, 2025 at 05:08:45PM +0100, Conor Dooley wrote:
> > > On Fri, Jun 06, 2025 at 03:21:02PM +0200, Jorge Marques wrote:
> > > > Add bindings doc for ADI I3C Controller IP core, a FPGA synthesizable IP
> > > > core that implements the MIPI I3C Basic controller specification.
> > > > 
> > > > Signed-off-by: Jorge Marques <jorge.marques@...log.com>
> > > > ---
> > > >  .../devicetree/bindings/i3c/adi,i3c-master.yaml    | 63 ++++++++++++++++++++++
> > > >  MAINTAINERS                                        |  5 ++
> > > >  2 files changed, 68 insertions(+)
> > > > 
> > > > diff --git a/Documentation/devicetree/bindings/i3c/adi,i3c-master.yaml b/Documentation/devicetree/bindings/i3c/adi,i3c-master.yaml
> > > > new file mode 100644
> > > > index 0000000000000000000000000000000000000000..e7fae394ad8fd4143eb1fffb9591a30a2d6cc6ac
> > > > --- /dev/null
> > > > +++ b/Documentation/devicetree/bindings/i3c/adi,i3c-master.yaml
> > > > @@ -0,0 +1,63 @@
> > > > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> > > > +%YAML 1.2
> > > > +---
> > > > +$id: http://devicetree.org/schemas/i3c/adi,i3c-master.yaml#
> > > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > > +
> > > > +title: Analog Devices I3C Controller
> > > > +
> > > > +description: |
> > > > +  The ADI I3C controller implements a subset of the I3C-basic specification to
> > > > +  interface I3C and I2C peripherals [1].
> > > > +
> > > > +  [1] https://analogdevicesinc.github.io/hdl/library/i3c_controller
> > > > +
> > > > +maintainers:
> > > > +  - Jorge Marques <jorge.marques@...log.com>
> > > > +
> > > > +properties:
> > > > +  compatible:
> > > > +    const: adi,i3c-master
> > > 
> > Hi Conor,
> > > Seeing this with no versioning info is pretty suspect.
> > > The adi spi, pwm, axi-dmac etc all have versioning info, please try to
> > > emulate that.
> > > 
> > > Otherwise, I think this is okay.
> > > 
> > > Cheers,
> > > Conor.
> > > 
> > The driver checks the IP version via register access, for the other adi
> > ips, the -x.00.a suffix was never updated. For example, the axi-dmac
> > current IP version is v4.5.64 while the compatible still is 1.00.a and
> > there is a mention of v4.3.a in the binding. It is unclear whether
> > suffixing it with "-1.00.a" would be useful, or if the time comes call
> > the new "adi,i3c-master-2".
> > 
> > Do you still think it is necessary?
> 
Hi Conor,

> I do, yes. In the other cases, if a new version comes out that has some
> sort of meaningful difference a new compatible can be added. Until then,
> using the -1.00.a one is okay.

Ok, I will add the -1.00.a suffix,

Best regards,
Jorge