linux-kernel - Re: [PATCH] fs/buffer: fix comments to reflect logical block size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ji24aaha6kcsemgagfw7expdesxcbrbd2uxxaonuof56xlbzog@sgewqljkd5qd>
Date: Wed, 18 Jun 2025 09:57:03 +0200
From: "Pankaj Raghav (Samsung)" <kernel@...kajraghav.com>
To: "Martin K. Petersen" <martin.petersen@...cle.com>
Cc: Pankaj Raghav <p.raghav@...sung.com>, 
	Alexander Viro <viro@...iv.linux.org.uk>, Jan Kara <jack@...e.cz>, Christian Brauner <brauner@...nel.org>, 
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fs/buffer: fix comments to reflect logical block size

On Tue, Jun 17, 2025 at 09:48:50PM -0400, Martin K. Petersen wrote:
> 
> Hi Pankaj!
> 
> > -	/* Size must be multiple of hard sectorsize */
> > +	/* Size must be multiple of logical block size */
> >  	if (unlikely(size & (bdev_logical_block_size(bdev)-1) ||
> >  			(size < 512 || size > PAGE_SIZE))) {
> >  		printk(KERN_ERR "getblk(): invalid block size %d requested\n",
> 
> OK with me. However, maybe that comment should just go away? The code on
> the following line articulates the constraint very clearly.
> 
> If you tweak things, please fix the spacing for "(bdev)-1".

That makes sense. I will send a v2.
> 
> Either way:
> 
> Reviewed-by: Martin K. Petersen <martin.petersen@...cle.com>
> 

Thanks
> -- 
> Martin K. Petersen

-- 
Pankaj Raghav