linux-kernel - Re: [PATCH] fs/buffer: fix comments to reflect logical block size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <yq1msa5x218.fsf@ca-mkp.ca.oracle.com>
Date: Tue, 17 Jun 2025 21:48:50 -0400
From: "Martin K. Petersen" <martin.petersen@...cle.com>
To: Pankaj Raghav <p.raghav@...sung.com>
Cc: Alexander Viro <viro@...iv.linux.org.uk>, Jan Kara <jack@...e.cz>,
        Christian Brauner <brauner@...nel.org>,
        "Martin K . Petersen"
 <martin.petersen@...cle.com>,
        <linux-fsdevel@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <kernel@...kajraghav.com>
Subject: Re: [PATCH] fs/buffer: fix comments to reflect logical block size


Hi Pankaj!

> -	/* Size must be multiple of hard sectorsize */
> +	/* Size must be multiple of logical block size */
>  	if (unlikely(size & (bdev_logical_block_size(bdev)-1) ||
>  			(size < 512 || size > PAGE_SIZE))) {
>  		printk(KERN_ERR "getblk(): invalid block size %d requested\n",

OK with me. However, maybe that comment should just go away? The code on
the following line articulates the constraint very clearly.

If you tweak things, please fix the spacing for "(bdev)-1".

Either way:

Reviewed-by: Martin K. Petersen <martin.petersen@...cle.com>

-- 
Martin K. Petersen