linux-kernel - Re: [PATCH V3] implement `ww_mutex` abstraction for the Rust tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250619173344.6c72c48a@nimda.home>
Date: Thu, 19 Jun 2025 17:33:44 +0300
From: Onur <work@...rozkan.dev>
To: Peter Zijlstra <peterz@...radead.org>
Cc: rust-for-linux@...r.kernel.org, linux-kernel@...r.kernel.org,
 mingo@...hat.com, will@...nel.org, boqun.feng@...il.com,
 longman@...hat.com, ojeda@...nel.org, alex.gaynor@...il.com,
 gary@...yguo.net, bjorn3_gh@...tonmail.com, lossin@...nel.org,
 a.hindborg@...nel.org, aliceryhl@...gle.com, tmgross@...ch.edu,
 dakr@...nel.org, thatslyude@...il.com
Subject: Re: [PATCH V3] implement `ww_mutex` abstraction for the Rust tree

On Thu, 19 Jun 2025 16:14:01 +0200
Peter Zijlstra <peterz@...radead.org> wrote:

> On Thu, Jun 19, 2025 at 05:06:56PM +0300, Onur Özkan wrote:
> > +bool rust_helper_ww_mutex_is_locked(struct ww_mutex *lock)
> > +{
> > +	return ww_mutex_is_locked(lock);
> > +}
> 
> Do we really need this? In general I dislike all the _is_locked()
> functions and would ideally like to remove them.
> 
> Pretty much the only useful pattern for any of the _is_locked()
> functions is:
> 
>   WARN_ON_ONCE(!foo_is_locked(&foo));
> 
> Any other use is dodgy as heck.
> 
> 

It's an abstraction of `ww_mutex_is_locked`. Since this is an
abstraction module, as long as `ww_mutex_is_locked` exists I think
we should keep it. FWIW it's also quite useful for tests.