lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <2025061916-overcoat-deduce-5a62@gregkh>
Date: Thu, 19 Jun 2025 17:30:25 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: Eric Florin <ericflorin@...gle.com>
Cc: teddy.wang@...iconmotion.com, sudipm.mukherjee@...il.com,
	linux-fbdev@...r.kernel.org, linux-staging@...ts.linux.dev,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 6/6] staging: sm750fb: Rename local var `nDirection`

On Tue, May 27, 2025 at 10:11:28AM -0700, Eric Florin wrote:
> Rename local variable `nDirection` to `n_direction` in
> `sm750_hw_copyarea` to conform with kernel style guidelines as reported
> by checkpatch.pl
> 
> CHECK: Avoid CamelCase: <nDirection>
> 
> Signed-off-by: Eric Florin <ericflorin@...gle.com>
> ---
>  drivers/staging/sm750fb/sm750_accel.c | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/staging/sm750fb/sm750_accel.c
> index a34d8f6a033d..b9f90c934b7d 100644
> --- a/drivers/staging/sm750fb/sm750_accel.c
> +++ b/drivers/staging/sm750fb/sm750_accel.c
> @@ -153,9 +153,9 @@ int sm750_hw_copyarea(struct lynx_accel *accel,
>  		      unsigned int width, unsigned int height,
>  		      unsigned int rop2)
>  {
> -	unsigned int nDirection, de_ctrl;
> +	unsigned int n_direction, de_ctrl;

Why keep the "n" at all?


Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ