linux-kernel - Re: [PATCH 1/6] staging: sm750fb: rename `sBase` parameter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2025061908-snore-pesticide-1389@gregkh>
Date: Thu, 19 Jun 2025 17:29:24 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: Eric Florin <ericflorin@...gle.com>
Cc: teddy.wang@...iconmotion.com, sudipm.mukherjee@...il.com,
	linux-fbdev@...r.kernel.org, linux-staging@...ts.linux.dev,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/6] staging: sm750fb: rename `sBase` parameter

On Tue, May 27, 2025 at 10:11:23AM -0700, Eric Florin wrote:
> Rename `sBase` to `s_base` in `sm750_hw_copyarea` to conform with style
> guidelines as reported by checkpatch.pl
> 
> CHECK: Avoid CamelCase: <sBase>
> 
> Signed-off-by: Eric Florin <ericflorin@...gle.com>
> ---
>  drivers/staging/sm750fb/sm750_accel.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/staging/sm750fb/sm750_accel.c
> index 44b9e3fe3a41..74e4be8103ac 100644
> --- a/drivers/staging/sm750fb/sm750_accel.c
> +++ b/drivers/staging/sm750fb/sm750_accel.c
> @@ -132,7 +132,7 @@ int sm750_hw_fillrect(struct lynx_accel *accel,
>  /**
>   * sm750_hw_copyarea
>   * @accel: Acceleration device data
> - * @sBase: Address of source: offset in frame buffer
> + * @s_base: Address of source: offset in frame buffer

Wouldn't a better name be "source_base"?

thanks,

greg k-h