linux-kernel - Re: [PATCH v3 3/5] arm64: dts: rockchip: add header for RK8XX PMIC constants

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <t3wbjpbw7phqvip4yvxm5kux6hor5pehzamrw6hjv3hq2b3j3n@zuf2vuhgpdpp>
Date: Thu, 19 Jun 2025 17:51:37 +0200
From: Sebastian Reichel <sebastian.reichel@...labora.com>
To: Quentin Schulz <foss+kernel@...il.net>
Cc: Lee Jones <lee@...nel.org>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Heiko Stuebner <heiko@...ech.de>, Lukasz Czechowski <lukasz.czechowski@...umatec.com>, 
	Daniel Semkowicz <dse@...umatec.com>, Nicolas Frattaroli <nicolas.frattaroli@...labora.com>, 
	devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, 
	linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org, 
	Quentin Schulz <quentin.schulz@...rry.de>
Subject: Re: [PATCH v3 3/5] arm64: dts: rockchip: add header for RK8XX PMIC
 constants

Hi,

On Wed, Jun 18, 2025 at 12:32:42PM +0200, Quentin Schulz wrote:
> From: Quentin Schulz <quentin.schulz@...rry.de>
> 
> To make it easier to read the device tree, let's add constants for the
> rockchip,reset-mode property values that are currently only applicable
> to RK806 PMIC.
> 
> Signed-off-by: Quentin Schulz <quentin.schulz@...rry.de>
> ---
>  arch/arm64/boot/dts/rockchip/rk8xx.h | 18 ++++++++++++++++++

I think this header should be in include/dt-bindings/, otherwise the
series LGTM.

Greetings,

-- Sebastian

>  1 file changed, 18 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk8xx.h b/arch/arm64/boot/dts/rockchip/rk8xx.h
> new file mode 100644
> index 0000000000000000000000000000000000000000..a6fbef71c06493c35b0f3697476167aaafa24f30
> --- /dev/null
> +++ b/arch/arm64/boot/dts/rockchip/rk8xx.h
> @@ -0,0 +1,18 @@
> +/* SPDX-License-Identifier: (GPL-2.0-or-later OR MIT) */
> +/*
> + * Device Tree defines for Rockchip RK8xx PMICs
> + *
> + * Copyright 2025 Cherry Embedded Solutions GmbH
> + *
> + * Author: Quentin Schulz <quentin.schulz@...rry.de>
> + */
> +
> +#ifndef _DT_MFD_ROCKCHIP_RK8XX_H
> +#define _DT_MFD_ROCKCHIP_RK8XX_H
> +
> +/* For use with rockchip,reset-mode property */
> +#define RK806_RESTART		0
> +#define RK806_RESET		1
> +#define RK806_RESET_NOTIFY	2
> +
> +#endif
> 
> -- 
> 2.49.0
> 

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)