linux-kernel - Re: [PATCH] coresight: Replace scnprintf() with sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7f9f123c-d7f9-478b-b207-f448a95d992a@linaro.org>
Date: Thu, 19 Jun 2025 16:53:47 +0100
From: James Clark <james.clark@...aro.org>
To: Chelsy Ratnawat <chelsyratnawat2001@...il.com>, suzuki.poulose@....com,
 alexander.shishkin@...ux.intel.com, mike.leach@...aro.org
Cc: coresight@...ts.linaro.org, linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] coresight: Replace scnprintf() with sysfs_emit() in sysfs
 show functions



On 19/06/2025 4:07 pm, Chelsy Ratnawat wrote:
> Replace calls to scnprintf() with sysfs_emit() in sysfs show functions.
> These helpers are preferred in sysfs callbacks because they automatically
> handle buffer sizing (PAGE_SIZE) and improve safety and readability.
> 
> Signed-off-by: Chelsy Ratnawat <chelsyratnawat2001@...il.com>
> ---
>   .../hwtracing/coresight/coresight-etm-perf.c  |   4 +-
>   .../coresight/coresight-etm3x-sysfs.c         |   2 +-
>   .../coresight/coresight-etm4x-sysfs.c         | 108 +++++++++---------
>   drivers/hwtracing/coresight/coresight-stm.c   |   8 +-

There's two missing from coresight-sysfs.c. Might as well change those 
too while were here.

With those changed:

Reviewed-by: James Clark <james.clark@...aro.org>