linux-kernel - Re: [PATCH] Revert "regulator: tps65219: Add TI TPS65214 Regulator Support"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250619193038.4e1f42c8@akair>
Date: Thu, 19 Jun 2025 19:30:38 +0200
From: Andreas Kemnade <andreas@...nade.info>
To: Dhruva Gole <d-gole@...com>
Cc: <s-ramamoorthy@...com>, <lgirdwood@...il.com>, <broonie@...nel.org>,
 <aaro.koskinen@....fi>, <khilman@...libre.com>, <rogerq@...nel.org>,
 <tony@...mide.com>, <linux-omap@...r.kernel.org>,
 <linux-kernel@...r.kernel.org>, <m-leonard@...com>, <praneeth@...com>,
 Robert Nelson <robertcnelson@...il.com>
Subject: Re: [PATCH] Revert "regulator: tps65219: Add TI TPS65214 Regulator
 Support"

Am Thu, 19 Jun 2025 21:05:26 +0530
schrieb Dhruva Gole <d-gole@...com>:

> This reverts commit f1471bc435afa31c8c0c58551922830dc8f4b06b.
> 
> This was causing boot regressions [1] on many BeagleBoard platforms
> like the AM62x based BeaglePlay and PocketBeagle-2.
> 
> [1] https://gist.github.com/DhruvaG2000/75b7d5ced6c09d508ee0ad5ab1f19707
> 
> Signed-off-by: Dhruva Gole <d-gole@...com>https://gist.github.com/DhruvaG2000/75b7d5ced6c09d508ee0ad5ab1f19707
> ---
hmm, do you need to really revert everything? Apparently some code
slipped through affecting the tps65219.

[..]
>  static const struct regulator_desc tps65219_regs[] = {
> -	TPS65219_REGULATOR("LDO1", "ldo1", TPS65219_LDO_1,
> -			   REGULATOR_VOLTAGE, ldos_1_2_ops, 64,
> -			   TPS65219_REG_LDO1_VOUT,
> -			   TPS65219_BUCKS_LDOS_VOUT_VSET_MASK,
> -			   TPS65219_REG_ENABLE_CTRL,
> -			   TPS65219_ENABLE_LDO1_EN_MASK, 0, 0, ldo_1_range,
> -			   2, 0, 0, NULL, 0, TPS65219_LDOS_BYP_CONFIG_MASK),
>  	TPS65219_REGULATOR("LDO2", "ldo2", TPS65219_LDO_2,
>  			   REGULATOR_VOLTAGE, ldos_1_2_ops, 64,
>  			   TPS65219_REG_LDO2_VOUT,
> @@ -366,23 +326,13 @@ struct tps65219_chip_data {
>  };

e.g. this.

I think it should be relatively easy to only revert that part without
needing to revert it fully.

Regards,
Andreas