linux-kernel - Re: [PATCH] Revert "regulator: tps65219: Add TI TPS65214 Regulator Support"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d526be6f-efe9-4f05-b8e1-9a80e4d92a36@sirena.org.uk>
Date: Thu, 19 Jun 2025 19:13:23 +0100
From: Mark Brown <broonie@...nel.org>
To: Andreas Kemnade <andreas@...nade.info>
Cc: Dhruva Gole <d-gole@...com>, s-ramamoorthy@...com, lgirdwood@...il.com,
	aaro.koskinen@....fi, khilman@...libre.com, rogerq@...nel.org,
	tony@...mide.com, linux-omap@...r.kernel.org,
	linux-kernel@...r.kernel.org, m-leonard@...com, praneeth@...com,
	Robert Nelson <robertcnelson@...il.com>
Subject: Re: [PATCH] Revert "regulator: tps65219: Add TI TPS65214 Regulator
 Support"

On Thu, Jun 19, 2025 at 07:30:38PM +0200, Andreas Kemnade wrote:
> Am Thu, 19 Jun 2025 21:05:26 +0530
> schrieb Dhruva Gole <d-gole@...com>:
> 
> > This reverts commit f1471bc435afa31c8c0c58551922830dc8f4b06b.

> >  	TPS65219_REGULATOR("LDO2", "ldo2", TPS65219_LDO_2,
> >  			   REGULATOR_VOLTAGE, ldos_1_2_ops, 64,
> >  			   TPS65219_REG_LDO2_VOUT,
> > @@ -366,23 +326,13 @@ struct tps65219_chip_data {
> >  };

> I think it should be relatively easy to only revert that part without
> needing to revert it fully.

Yes, I'd like to see some analysis as to why a revert is a good fix
here, it doesn't seem like there's been any effort at understanding what
went wrong and the change doesn't seem that complex.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)