[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID:
<AS8PR04MB86765037AB641C982FBF720A8C7DA@AS8PR04MB8676.eurprd04.prod.outlook.com>
Date: Thu, 19 Jun 2025 03:39:15 +0000
From: Hongxing Zhu <hongxing.zhu@....com>
To: Krzysztof Kozlowski <krzk@...nel.org>, Frank Li <frank.li@....com>,
"l.stach@...gutronix.de" <l.stach@...gutronix.de>, "lpieralisi@...nel.org"
<lpieralisi@...nel.org>, "kwilczynski@...nel.org" <kwilczynski@...nel.org>,
"mani@...nel.org" <mani@...nel.org>, "robh@...nel.org" <robh@...nel.org>,
"bhelgaas@...gle.com" <bhelgaas@...gle.com>, "shawnguo@...nel.org"
<shawnguo@...nel.org>, "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
"kernel@...gutronix.de" <kernel@...gutronix.de>, "festevam@...il.com"
<festevam@...il.com>
CC: "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>, "imx@...ts.linux.dev"
<imx@...ts.linux.dev>, "linux-kernel@...r.kernel.org"
<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v1 1/2] dt-binding: pci-imx6: Add external reference clock
mode support
> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@...nel.org>
> Sent: 2025年6月18日 21:44
> To: Hongxing Zhu <hongxing.zhu@....com>; Frank Li <frank.li@....com>;
> l.stach@...gutronix.de; lpieralisi@...nel.org; kwilczynski@...nel.org;
> mani@...nel.org; robh@...nel.org; bhelgaas@...gle.com;
> shawnguo@...nel.org; s.hauer@...gutronix.de; kernel@...gutronix.de;
> festevam@...il.com
> Cc: linux-pci@...r.kernel.org; linux-arm-kernel@...ts.infradead.org;
> imx@...ts.linux.dev; linux-kernel@...r.kernel.org
> Subject: Re: [PATCH v1 1/2] dt-binding: pci-imx6: Add external reference clock
> mode support
>
> On 18/06/2025 09:48, Richard Zhu wrote:
> > On i.MX, the PCIe reference clock might come from either internal
> > system PLL or external clock source.
> > Add the external reference clock source for reference clock.
> >
> > Signed-off-by: Richard Zhu <hongxing.zhu@....com>
> > ---
> > Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml | 7 ++++++-
> > 1 file changed, 6 insertions(+), 1 deletion(-)
>
> <form letter>
> Please use scripts/get_maintainers.pl to get a list of necessary people and
> lists to CC. It might happen, that command when run on an older kernel, gives
> you outdated entries. Therefore please be sure you base your patches on
> recent Linux kernel.
>
> Tools like b4 or scripts/get_maintainer.pl provide you proper list of people, so
> fix your workflow. Tools might also fail if you work on some ancient tree (don't,
> instead use mainline) or work on fork of kernel (don't, instead use mainline).
> Just use b4 and everything should be fine, although remember about `b4 prep
> --auto-to-cc` if you added new patches to the patchset.
>
> You missed at least devicetree list (maybe more), so this won't be tested by
> automated tooling. Performing review on untested code might be a waste of
> time.
>
> Please kindly resend and include all necessary To/Cc entries.
> </form letter>
Hi Krzysztof:
Thanks a lot for your kindly reminder.
After correct the list of necessary people and lists.
Would resend the v1 series, address the comments, then send out v2 later.
Best Regards
Richard Zhu
>
> Best regards,
> Krzysztof
Powered by blists - more mailing lists