linux-kernel - Re: [PATCH] Revert "platform/x86: alienware-wmi-wmax: Add G-Mode support to Alienware m16 R1"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c5180008b4611f61866b216eb20f8db2e7ef429e.camel@yandex.ru>
Date: Thu, 19 Jun 2025 09:24:34 +0300
From: Konstantin Kharlamov <Hi-Angel@...dex.ru>
To: Kurt Borja <kuurtb@...il.com>, Hans de Goede <hdegoede@...hat.com>, Ilpo
 Järvinen <ilpo.jarvinen@...ux.intel.com>, Armin Wolf
 <W_Armin@....de>
Cc: platform-driver-x86@...r.kernel.org, Dell.Client.Kernel@...l.com, 
	linux-kernel@...r.kernel.org, Cihan Ozakca <cozakca@...look.com>, 
	stable@...r.kernel.org
Subject: Re: [PATCH] Revert "platform/x86: alienware-wmi-wmax: Add G-Mode
 support to Alienware m16 R1"

On Wed, 2025-06-11 at 18:30 -0300, Kurt Borja wrote:
> This reverts commit 5ff79cabb23a2f14d2ed29e9596aec908905a0e6.
> 
> Although the Alienware m16 R1 AMD model supports G-Mode, it actually
> has
> a lower power ceiling than plain "performance" profile, which results
> in
> lower performance.
> 
> Reported-by: Cihan Ozakca <cozakca@...look.com>
> Cc: stable@...r.kernel.org # 6.15.x
> Signed-off-by: Kurt Borja <kuurtb@...il.com>
> ---
> Hi all,
> 
> Contrary to (my) intuition, imitating Windows behavior actually
> results
> in LOWER performance.
> 
> I was having second thoughts about this revert because users will
> notice
> that "performance" not longer turns on the G-Mode key found in this
> laptop. Some users may think this is actually a regression, but IMO
> lower performance is worse.
> ---
>  drivers/platform/x86/dell/alienware-wmi-wmax.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/x86/dell/alienware-wmi-wmax.c
> b/drivers/platform/x86/dell/alienware-wmi-wmax.c
> index
> c42f9228b0b255fe962b735ac96486824e83945f..20ec122a9fe0571a1ecd2ccf630
> 615564ab30481 100644
> --- a/drivers/platform/x86/dell/alienware-wmi-wmax.c
> +++ b/drivers/platform/x86/dell/alienware-wmi-wmax.c
> @@ -119,7 +119,7 @@ static const struct dmi_system_id
> awcc_dmi_table[] __initconst = {
>  			DMI_MATCH(DMI_SYS_VENDOR, "Alienware"),
>  			DMI_MATCH(DMI_PRODUCT_NAME, "Alienware m16
> R1 AMD"),
>  		},
> -		.driver_data = &g_series_quirks,
> +		.driver_data = &generic_quirks,
>  	},
>  	{
>  		.ident = "Alienware m16 R2",

I think, at least a code comment explaining the situation is warranted
(or maybe even a print on keypress or both), because otherwise sometime
in the future other people may try to add the functional back, and then
yet other people may again revert it, regressing things back and forth.