linux-kernel - Re: [RFC PATCH v8 3/7] mm/filemap: Add mempolicy support to the filemap layer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aFVxa-PRavav6pNd@casper.infradead.org>
Date: Fri, 20 Jun 2025 15:34:19 +0100
From: Matthew Wilcox <willy@...radead.org>
To: Shivank Garg <shivankg@....com>
Cc: seanjc@...gle.com, david@...hat.com, vbabka@...e.cz,
	akpm@...ux-foundation.org, shuah@...nel.org, pbonzini@...hat.com,
	brauner@...nel.org, viro@...iv.linux.org.uk, ackerleytng@...gle.com,
	paul@...l-moore.com, jmorris@...ei.org, serge@...lyn.com,
	pvorel@...e.cz, bfoster@...hat.com, tabba@...gle.com,
	vannapurve@...gle.com, chao.gao@...el.com, bharata@....com,
	nikunj@....com, michael.day@....com, yan.y.zhao@...el.com,
	Neeraj.Upadhyay@....com, thomas.lendacky@....com,
	michael.roth@....com, aik@....com, jgg@...dia.com,
	kalyazin@...zon.com, peterx@...hat.com, jack@...e.cz,
	rppt@...nel.org, hch@...radead.org, cgzones@...glemail.com,
	ira.weiny@...el.com, rientjes@...gle.com, roypat@...zon.co.uk,
	ziy@...dia.com, matthew.brost@...el.com, joshua.hahnjy@...il.com,
	rakie.kim@...com, byungchul@...com, gourry@...rry.net,
	kent.overstreet@...ux.dev, ying.huang@...ux.alibaba.com,
	apopple@...dia.com, chao.p.peng@...el.com, amit@...radead.org,
	ddutile@...hat.com, dan.j.williams@...el.com, ashish.kalra@....com,
	gshan@...hat.com, jgowans@...zon.com, pankaj.gupta@....com,
	papaluri@....com, yuzhao@...gle.com, suzuki.poulose@....com,
	quic_eberman@...cinc.com, aneeshkumar.kizhakeveetil@....com,
	linux-fsdevel@...r.kernel.org, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org, linux-security-module@...r.kernel.org,
	kvm@...r.kernel.org, linux-kselftest@...r.kernel.org,
	linux-coco@...ts.linux.dev
Subject: Re: [RFC PATCH v8 3/7] mm/filemap: Add mempolicy support to the
 filemap layer

On Fri, Jun 20, 2025 at 11:29:20AM +0530, Shivank Garg wrote:
> filemap_grab_folio_mpol() is used in [Patch 6/7] in kvm_gmem_prepare_folio().
> 
> filemap_alloc_folio_mpol() and __filemap_get_folio_mpol()) are internally used
> to support the filemap_grab_folio_mpol().

That's not better.  We don't add unused functions, and unless there's
something coming that's going to use them, the entire structure of this
is wrong.

filemap_grab_folio() is a convenience function that avoids us having to
specify the other two arguments to __filemap_get_folio().  Since there's
no indication at this point that there are going to be more callers of
it, filemap_grab_folio_mpol() should not even exist.

I'll send a pair of patches which should be sufficient for your needs.