linux-kernel - Re: [RFC PATCH v8 3/7] mm/filemap: Add mempolicy support to the filemap layer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <49455248-04b5-465e-9c76-b5dfbe6ac329@suse.cz>
Date: Fri, 20 Jun 2025 11:37:28 +0200
From: Vlastimil Babka <vbabka@...e.cz>
To: Shivank Garg <shivankg@....com>, Matthew Wilcox <willy@...radead.org>
Cc: seanjc@...gle.com, david@...hat.com, akpm@...ux-foundation.org,
 shuah@...nel.org, pbonzini@...hat.com, brauner@...nel.org,
 viro@...iv.linux.org.uk, ackerleytng@...gle.com, paul@...l-moore.com,
 jmorris@...ei.org, serge@...lyn.com, pvorel@...e.cz, bfoster@...hat.com,
 tabba@...gle.com, vannapurve@...gle.com, chao.gao@...el.com,
 bharata@....com, nikunj@....com, michael.day@....com, yan.y.zhao@...el.com,
 Neeraj.Upadhyay@....com, thomas.lendacky@....com, michael.roth@....com,
 aik@....com, jgg@...dia.com, kalyazin@...zon.com, peterx@...hat.com,
 jack@...e.cz, rppt@...nel.org, hch@...radead.org, cgzones@...glemail.com,
 ira.weiny@...el.com, rientjes@...gle.com, roypat@...zon.co.uk,
 ziy@...dia.com, matthew.brost@...el.com, joshua.hahnjy@...il.com,
 rakie.kim@...com, byungchul@...com, gourry@...rry.net,
 kent.overstreet@...ux.dev, ying.huang@...ux.alibaba.com, apopple@...dia.com,
 chao.p.peng@...el.com, amit@...radead.org, ddutile@...hat.com,
 dan.j.williams@...el.com, ashish.kalra@....com, gshan@...hat.com,
 jgowans@...zon.com, pankaj.gupta@....com, papaluri@....com,
 yuzhao@...gle.com, suzuki.poulose@....com, quic_eberman@...cinc.com,
 aneeshkumar.kizhakeveetil@....com, linux-fsdevel@...r.kernel.org,
 linux-mm@...ck.org, linux-kernel@...r.kernel.org,
 linux-security-module@...r.kernel.org, kvm@...r.kernel.org,
 linux-kselftest@...r.kernel.org, linux-coco@...ts.linux.dev
Subject: Re: [RFC PATCH v8 3/7] mm/filemap: Add mempolicy support to the
 filemap layer

On 6/20/25 07:59, Shivank Garg wrote:
> 
> 
> On 6/19/2025 9:33 PM, Matthew Wilcox wrote:
>> On Wed, Jun 18, 2025 at 11:29:31AM +0000, Shivank Garg wrote:
>>> From: Shivansh Dhiman <shivansh.dhiman@....com>
>>>
>>> Add NUMA mempolicy support to the filemap allocation path by introducing
>>> new APIs that take a mempolicy argument:
>>> - filemap_grab_folio_mpol()
>>> - filemap_alloc_folio_mpol()
>>> - __filemap_get_folio_mpol()
>> 
>> You don't use these APIs in this series, so I can't evaludate whether
>> any of my suggestiosn for improving this patch would actually work.
>> NACK.  Introduce the APIs *with a user*.  Come on, this isn't a new
>> requirement.
> 
> Hi willy,
> 
> Thank you for the feedback.
> 
> filemap_grab_folio_mpol() is used in [Patch 6/7] in kvm_gmem_prepare_folio().
> 
> filemap_alloc_folio_mpol() and __filemap_get_folio_mpol()) are internally used
> to support the filemap_grab_folio_mpol().

Maybe they can be static then and don't need to be declared in the header.

> Thanks,
> Shivank