linux-kernel - Re: [PATCH] regulator: tps65219: Fix devm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOCHtYjYTfrJ_pNCsQOXX7Hj6A7wBXKdMQYvog-5h-=WLtorhw@mail.gmail.com>
Date: Fri, 20 Jun 2025 09:52:52 -0500
From: Robert Nelson <robertcnelson@...il.com>
To: Shree Ramamoorthy <s-ramamoorthy@...com>
Cc: aaro.koskinen@....fi, andreas@...nade.info, khilman@...libre.com, 
	rogerq@...nel.org, tony@...mide.com, lee@...nel.org, d-gole@...com, 
	jkridner@...il.com, linux-omap@...r.kernel.org, linux-kernel@...r.kernel.org, 
	m-leonard@...com, praneeth@...com, afd@...com
Subject: Re: [PATCH] regulator: tps65219: Fix devm_kmalloc size allocation

On Fri, Jun 20, 2025 at 8:30 AM Robert Nelson <robertcnelson@...il.com> wrote:
>
> On Thu, Jun 19, 2025 at 7:09 PM Shree Ramamoorthy <s-ramamoorthy@...com> wrote:
> >
> > In probe(), devm_kmalloc uses pmic->common_irq_size to allocate an array of
> > 2 bytes, but pmic->common_irq_size is being used like an array of structs.
> > The param sent should've been pmic->common_irq_size * sizeof(*irq_data).
> > This led to an issue with the kmalloc'd buffer being corrupted and EVM boot
> > issues. The common and device-specific structs are now allocated one at a
> > time within the loop.
> >
> > Fixes: 38c9f98db20a ("regulator: tps65219: Add support for TPS65215 Regulator IRQs")
> > Reported-by: Dhruva Gole <d-gole@...com>
> > Signed-off-by: Shree Ramamoorthy <s-ramamoorthy@...com>

Sweet!  With 4 PB2's and 2 BeaglePlays... Power on, boot, Power off,
wait 30 seconds.. (repeat 10 times)

Before:
36/60: Bootup to File System

After
60/60: Bootup to File System

Tested-by: Robert Nelson <robertcnelson@...il.com>

SInce i applied directly to rc2, here's my fixup of your patch for
reference: https://github.com/RobertCNelson/arm64-multiplatform/blob/v6.16.x-arm64-k3/patches/fixes/0001-regulator-tps65219-Fix-devm_kmalloc-size-allocation.patch

For TI, we also need to cherry pick this in v6.12.x-ti, to fix
BeaglePlay and PB2..

Thanks Everyone!

-- 
Robert Nelson
https://rcn-ee.com/